mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
104 lines
3.3 KiB
JavaScript
104 lines
3.3 KiB
JavaScript
/* eslint-disable no-unused-expressions */
|
|
import React from 'react';
|
|
import sinon from 'sinon';
|
|
import { shallow } from 'enzyme';
|
|
import VirtualizedSelect from 'react-virtualized-select';
|
|
import Select, { Creatable } from 'react-select';
|
|
|
|
import OnPasteSelect from '../../../src/components/OnPasteSelect';
|
|
|
|
const defaultProps = {
|
|
onChange: sinon.spy(),
|
|
multi: true,
|
|
isValidNewOption: sinon.spy(s => !!s.label),
|
|
value: [],
|
|
options: [
|
|
{ value: 'United States', label: 'United States' },
|
|
{ value: 'China', label: 'China' },
|
|
{ value: 'India', label: 'India' },
|
|
{ value: 'Canada', label: 'Canada' },
|
|
{ value: 'Russian Federation', label: 'Russian Federation' },
|
|
{ value: 'Japan', label: 'Japan' },
|
|
{ value: 'Mexico', label: 'Mexico' },
|
|
],
|
|
};
|
|
|
|
const defaultEvt = {
|
|
preventDefault: sinon.spy(),
|
|
clipboardData: {
|
|
getData: sinon.spy(() => ' United States, China , India, Canada, '),
|
|
},
|
|
};
|
|
|
|
describe('OnPasteSelect', () => {
|
|
let wrapper;
|
|
let props;
|
|
let evt;
|
|
let expected;
|
|
beforeEach(() => {
|
|
props = Object.assign({}, defaultProps);
|
|
wrapper = shallow(<OnPasteSelect {...props} />);
|
|
evt = Object.assign({}, defaultEvt);
|
|
});
|
|
|
|
it('renders the supplied selectWrap component', () => {
|
|
const select = wrapper.find(Select);
|
|
expect(select).toHaveLength(1);
|
|
});
|
|
|
|
it('renders custom selectWrap components', () => {
|
|
props.selectWrap = Creatable;
|
|
wrapper = shallow(<OnPasteSelect {...props} />);
|
|
expect(wrapper.find(Creatable)).toHaveLength(1);
|
|
props.selectWrap = VirtualizedSelect;
|
|
wrapper = shallow(<OnPasteSelect {...props} />);
|
|
expect(wrapper.find(VirtualizedSelect)).toHaveLength(1);
|
|
});
|
|
|
|
describe('onPaste', () => {
|
|
it('calls onChange with pasted values', () => {
|
|
wrapper.instance().onPaste(evt);
|
|
expected = props.options.slice(0, 4);
|
|
expect(props.onChange.calledWith(expected)).toBe(true);
|
|
expect(evt.preventDefault.called).toBe(true);
|
|
expect(props.isValidNewOption.callCount).toBe(5);
|
|
});
|
|
|
|
it('calls onChange without any duplicate values and adds new values', () => {
|
|
evt.clipboardData.getData = sinon.spy(() =>
|
|
'China, China, China, China, Mexico, Mexico, Chi na, Mexico, ',
|
|
);
|
|
expected = [
|
|
props.options[1],
|
|
props.options[6],
|
|
{ label: 'Chi na', value: 'Chi na' },
|
|
];
|
|
wrapper.instance().onPaste(evt);
|
|
expect(props.onChange.calledWith(expected)).toBe(true);
|
|
expect(evt.preventDefault.called).toBe(true);
|
|
expect(props.isValidNewOption.callCount).toBe(9);
|
|
expect(props.options[0].value).toBe(expected[2].value);
|
|
props.options.splice(0, 1);
|
|
});
|
|
|
|
it('calls onChange with currently selected values and new values', () => {
|
|
props.value = ['United States', 'Canada', 'Mexico'];
|
|
evt.clipboardData.getData = sinon.spy(() =>
|
|
'United States, Canada, Japan, India',
|
|
);
|
|
wrapper = shallow(<OnPasteSelect {...props} />);
|
|
expected = [
|
|
props.options[0],
|
|
props.options[3],
|
|
props.options[6],
|
|
props.options[5],
|
|
props.options[2],
|
|
];
|
|
wrapper.instance().onPaste(evt);
|
|
expect(props.onChange.calledWith(expected)).toBe(true);
|
|
expect(evt.preventDefault.called).toBe(true);
|
|
expect(props.isValidNewOption.callCount).toBe(11);
|
|
});
|
|
});
|
|
});
|