mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
81 lines
2.8 KiB
JavaScript
81 lines
2.8 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import DashboardComponent from '../../../../src/dashboard/containers/DashboardComponent';
|
|
import DashboardGrid from '../../../../src/dashboard/components/DashboardGrid';
|
|
import DragDroppable from '../../../../src/dashboard/components/dnd/DragDroppable';
|
|
import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';
|
|
|
|
import { DASHBOARD_GRID_TYPE } from '../../../../src/dashboard/util/componentTypes';
|
|
import { GRID_COLUMN_COUNT } from '../../../../src/dashboard/util/constants';
|
|
|
|
describe('DashboardGrid', () => {
|
|
const props = {
|
|
depth: 1,
|
|
editMode: false,
|
|
gridComponent: {
|
|
...newComponentFactory(DASHBOARD_GRID_TYPE),
|
|
children: ['a'],
|
|
},
|
|
handleComponentDrop() {},
|
|
resizeComponent() {},
|
|
width: 500,
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
const wrapper = shallow(<DashboardGrid {...props} {...overrideProps} />);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a div with class "dashboard-grid"', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find('.dashboard-grid')).toHaveLength(1);
|
|
});
|
|
|
|
it('should render one DashboardComponent for each gridComponent child', () => {
|
|
const wrapper = setup({
|
|
gridComponent: { ...props.gridComponent, children: ['a', 'b'] },
|
|
});
|
|
expect(wrapper.find(DashboardComponent)).toHaveLength(2);
|
|
});
|
|
|
|
it('should render two empty DragDroppables in editMode to increase the drop target zone', () => {
|
|
const viewMode = setup({ editMode: false });
|
|
const editMode = setup({ editMode: true });
|
|
expect(viewMode.find(DragDroppable)).toHaveLength(0);
|
|
expect(editMode.find(DragDroppable)).toHaveLength(2);
|
|
});
|
|
|
|
it('should render grid column guides when resizing', () => {
|
|
const wrapper = setup({ editMode: true });
|
|
expect(wrapper.find('.grid-column-guide')).toHaveLength(0);
|
|
|
|
wrapper.setState({ isResizing: true });
|
|
|
|
expect(wrapper.find('.grid-column-guide')).toHaveLength(GRID_COLUMN_COUNT);
|
|
});
|
|
|
|
it('should render a grid row guide when resizing', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find('.grid-row-guide')).toHaveLength(0);
|
|
wrapper.setState({ isResizing: true, rowGuideTop: 10 });
|
|
expect(wrapper.find('.grid-row-guide')).toHaveLength(1);
|
|
});
|
|
|
|
it('should call resizeComponent when a child DashboardComponent calls resizeStop', () => {
|
|
const resizeComponent = sinon.spy();
|
|
const args = { id: 'id', widthMultiple: 1, heightMultiple: 3 };
|
|
const wrapper = setup({ resizeComponent });
|
|
const dashboardComponent = wrapper.find(DashboardComponent).first();
|
|
dashboardComponent.prop('onResizeStop')(args);
|
|
|
|
expect(resizeComponent.callCount).toBe(1);
|
|
expect(resizeComponent.getCall(0).args[0]).toEqual({
|
|
id: 'id',
|
|
width: 1,
|
|
height: 3,
|
|
});
|
|
});
|
|
});
|