mirror of
https://github.com/apache/superset.git
synced 2026-04-11 12:26:05 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
241 lines
7.4 KiB
JavaScript
241 lines
7.4 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import Dashboard from '../../../../src/dashboard/components/Dashboard';
|
|
import DashboardBuilder from '../../../../src/dashboard/containers/DashboardBuilder';
|
|
|
|
// mock data
|
|
import chartQueries, { sliceId as chartId } from '../fixtures/mockChartQueries';
|
|
import datasources from '../../../fixtures/mockDatasource';
|
|
import dashboardInfo from '../fixtures/mockDashboardInfo';
|
|
import { dashboardLayout } from '../fixtures/mockDashboardLayout';
|
|
import dashboardState from '../fixtures/mockDashboardState';
|
|
import { sliceEntitiesForChart as sliceEntities } from '../fixtures/mockSliceEntities';
|
|
|
|
import { CHART_TYPE } from '../../../../src/dashboard/util/componentTypes';
|
|
import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';
|
|
|
|
describe('Dashboard', () => {
|
|
const props = {
|
|
actions: {
|
|
addSliceToDashboard() {},
|
|
removeSliceFromDashboard() {},
|
|
runQuery() {},
|
|
},
|
|
initMessages: [],
|
|
dashboardState,
|
|
dashboardInfo,
|
|
charts: chartQueries,
|
|
slices: sliceEntities.slices,
|
|
datasources,
|
|
layout: dashboardLayout.present,
|
|
timeout: 60,
|
|
userId: dashboardInfo.userId,
|
|
impressionId: 'id',
|
|
loadStats: {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
const wrapper = shallow(<Dashboard {...props} {...overrideProps} />);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a DashboardBuilder', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DashboardBuilder)).toHaveLength(1);
|
|
});
|
|
|
|
describe('refreshExcept', () => {
|
|
const overrideCharts = {
|
|
...chartQueries,
|
|
1001: {
|
|
...chartQueries[chartId],
|
|
id: 1001,
|
|
},
|
|
};
|
|
|
|
const overrideSlices = {
|
|
...props.slices,
|
|
1001: {
|
|
...props.slices[chartId],
|
|
slice_id: 1001,
|
|
},
|
|
};
|
|
|
|
it('should call runQuery for all non-exempt slices', () => {
|
|
const wrapper = setup({ charts: overrideCharts, slices: overrideSlices });
|
|
const spy = sinon.spy(props.actions, 'runQuery');
|
|
wrapper.instance().refreshExcept('1001');
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(Object.keys(overrideCharts).length - 1);
|
|
});
|
|
|
|
it('should not call runQuery for filter_immune_slices', () => {
|
|
const wrapper = setup({
|
|
charts: overrideCharts,
|
|
dashboardInfo: {
|
|
...dashboardInfo,
|
|
metadata: {
|
|
...dashboardInfo.metadata,
|
|
filter_immune_slices: Object.keys(overrideCharts).map(id =>
|
|
Number(id),
|
|
),
|
|
},
|
|
},
|
|
});
|
|
const spy = sinon.spy(props.actions, 'runQuery');
|
|
wrapper.instance().refreshExcept();
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('componentWillReceiveProps', () => {
|
|
const layoutWithExtraChart = {
|
|
...props.layout,
|
|
1001: newComponentFactory(CHART_TYPE, { chartId: 1001 }),
|
|
};
|
|
|
|
it('should call addSliceToDashboard if a new slice is added to the layout', () => {
|
|
const wrapper = setup();
|
|
const spy = sinon.spy(props.actions, 'addSliceToDashboard');
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
layout: layoutWithExtraChart,
|
|
});
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call removeSliceFromDashboard if a slice is removed from the layout', () => {
|
|
const wrapper = setup({ layout: layoutWithExtraChart });
|
|
const spy = sinon.spy(props.actions, 'removeSliceFromDashboard');
|
|
const nextLayout = { ...layoutWithExtraChart };
|
|
delete nextLayout[1001];
|
|
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
layout: nextLayout,
|
|
});
|
|
spy.restore();
|
|
expect(spy.callCount).toBe(1);
|
|
});
|
|
});
|
|
|
|
describe('componentDidUpdate', () => {
|
|
const overrideDashboardState = {
|
|
...dashboardState,
|
|
filters: {
|
|
1: { region: [] },
|
|
2: { country_name: ['USA'] },
|
|
},
|
|
refresh: true,
|
|
};
|
|
|
|
it('should not call refresh when there is no change', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
const prevProps = wrapper.instance().props;
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
},
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProps);
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
|
|
it('should call refresh if a filter is added', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
3: { another_filter: ['please'] },
|
|
},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call refresh if a filter is removed', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call refresh if a filter is changed', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(1);
|
|
});
|
|
|
|
it('should not call refresh if filters change and refresh is false', () => {
|
|
const wrapper = setup({ dashboardState: overrideDashboardState });
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
refresh: false,
|
|
},
|
|
});
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
|
|
it('should not refresh filter_immune_slices', () => {
|
|
const wrapper = setup({
|
|
dashboardState: overrideDashboardState,
|
|
dashboardInfo: {
|
|
...dashboardInfo,
|
|
metadata: {
|
|
...dashboardInfo.metadata,
|
|
filter_immune_slices: [chartId],
|
|
},
|
|
},
|
|
});
|
|
const refreshExceptSpy = sinon.spy(wrapper.instance(), 'refreshExcept');
|
|
const prevProps = wrapper.instance().props;
|
|
wrapper.setProps({
|
|
dashboardState: {
|
|
...overrideDashboardState,
|
|
filters: {
|
|
...overrideDashboardState.filters,
|
|
2: { country_name: ['Canada'] },
|
|
},
|
|
refresh: false,
|
|
},
|
|
});
|
|
wrapper.instance().componentDidUpdate(prevProps);
|
|
refreshExceptSpy.restore();
|
|
expect(refreshExceptSpy.callCount).toBe(0);
|
|
});
|
|
});
|
|
});
|