mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
153 lines
4.5 KiB
JavaScript
153 lines
4.5 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import { List } from 'react-virtualized';
|
|
|
|
import SliceAdder from '../../../../src/dashboard/components/SliceAdder';
|
|
import { sliceEntitiesForDashboard as mockSliceEntities } from '../fixtures/mockSliceEntities';
|
|
|
|
describe('SliceAdder', () => {
|
|
const mockEvent = {
|
|
key: 'Enter',
|
|
target: {
|
|
value: 'mock event target',
|
|
},
|
|
preventDefault: () => {},
|
|
};
|
|
const props = {
|
|
...mockSliceEntities,
|
|
fetchAllSlices: () => {},
|
|
selectedSliceIds: [127, 128],
|
|
userId: '1',
|
|
height: 100,
|
|
};
|
|
const errorProps = {
|
|
...props,
|
|
errorMessage: 'this is error',
|
|
};
|
|
|
|
describe('SliceAdder.sortByComparator', () => {
|
|
it('should sort by timestamp descending', () => {
|
|
const sortedTimestamps = Object.values(props.slices)
|
|
.sort(SliceAdder.sortByComparator('changed_on'))
|
|
.map(slice => slice.changed_on);
|
|
expect(
|
|
sortedTimestamps.every((currentTimestamp, index) => {
|
|
if (index === 0) {
|
|
return true;
|
|
}
|
|
return currentTimestamp < sortedTimestamps[index - 1];
|
|
}),
|
|
).toBe(true);
|
|
});
|
|
|
|
it('should sort by slice_name', () => {
|
|
const sortedNames = Object.values(props.slices)
|
|
.sort(SliceAdder.sortByComparator('slice_name'))
|
|
.map(slice => slice.slice_name);
|
|
const expectedNames = Object.values(props.slices)
|
|
.map(slice => slice.slice_name)
|
|
.sort();
|
|
expect(sortedNames).toEqual(expectedNames);
|
|
});
|
|
});
|
|
|
|
it('render List', () => {
|
|
const wrapper = shallow(<SliceAdder {...props} />);
|
|
wrapper.setState({ filteredSlices: Object.values(props.slices) });
|
|
expect(wrapper.find(List)).toHaveLength(1);
|
|
});
|
|
|
|
it('render error', () => {
|
|
const wrapper = shallow(<SliceAdder {...errorProps} />);
|
|
wrapper.setState({ filteredSlices: Object.values(props.slices) });
|
|
expect(wrapper.text()).toContain(errorProps.errorMessage);
|
|
});
|
|
|
|
it('componentDidMount', () => {
|
|
sinon.spy(SliceAdder.prototype, 'componentDidMount');
|
|
sinon.spy(props, 'fetchAllSlices');
|
|
|
|
shallow(<SliceAdder {...props} />, {
|
|
lifecycleExperimental: true,
|
|
});
|
|
expect(SliceAdder.prototype.componentDidMount.calledOnce).toBe(true);
|
|
expect(props.fetchAllSlices.calledOnce).toBe(true);
|
|
|
|
SliceAdder.prototype.componentDidMount.restore();
|
|
props.fetchAllSlices.restore();
|
|
});
|
|
|
|
describe('componentWillReceiveProps', () => {
|
|
let wrapper;
|
|
beforeEach(() => {
|
|
wrapper = shallow(<SliceAdder {...props} />);
|
|
wrapper.setState({ filteredSlices: Object.values(props.slices) });
|
|
sinon.spy(wrapper.instance(), 'setState');
|
|
});
|
|
afterEach(() => {
|
|
wrapper.instance().setState.restore();
|
|
});
|
|
|
|
it('fetch slices should update state', () => {
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
lastUpdated: new Date().getTime(),
|
|
});
|
|
expect(wrapper.instance().setState.calledOnce).toBe(true);
|
|
|
|
const stateKeys = Object.keys(
|
|
wrapper.instance().setState.lastCall.args[0],
|
|
);
|
|
expect(stateKeys).toContain('filteredSlices');
|
|
});
|
|
|
|
it('select slices should update state', () => {
|
|
wrapper.instance().componentWillReceiveProps({
|
|
...props,
|
|
selectedSliceIds: [127],
|
|
});
|
|
expect(wrapper.instance().setState.calledOnce).toBe(true);
|
|
|
|
const stateKeys = Object.keys(
|
|
wrapper.instance().setState.lastCall.args[0],
|
|
);
|
|
expect(stateKeys).toContain('selectedSliceIdsSet');
|
|
});
|
|
});
|
|
|
|
describe('should rerun filter and sort', () => {
|
|
let wrapper;
|
|
let spy;
|
|
beforeEach(() => {
|
|
wrapper = shallow(<SliceAdder {...props} />);
|
|
wrapper.setState({ filteredSlices: Object.values(props.slices) });
|
|
spy = sinon.spy(wrapper.instance(), 'getFilteredSortedSlices');
|
|
});
|
|
afterEach(() => {
|
|
spy.restore();
|
|
});
|
|
|
|
it('searchUpdated', () => {
|
|
const newSearchTerm = 'new search term';
|
|
wrapper.instance().searchUpdated(newSearchTerm);
|
|
expect(spy.calledOnce).toBe(true);
|
|
expect(spy.lastCall.args[0]).toBe(newSearchTerm);
|
|
});
|
|
|
|
it('handleSelect', () => {
|
|
const newSortBy = 1;
|
|
wrapper.instance().handleSelect(newSortBy);
|
|
expect(spy.calledOnce).toBe(true);
|
|
expect(spy.lastCall.args[1]).toBe(newSortBy);
|
|
});
|
|
|
|
it('handleKeyPress', () => {
|
|
wrapper.instance().handleKeyPress(mockEvent);
|
|
expect(spy.calledOnce).toBe(true);
|
|
expect(spy.lastCall.args[0]).toBe(mockEvent.target.value);
|
|
});
|
|
});
|
|
});
|