mirror of
https://github.com/apache/superset.git
synced 2026-04-09 19:35:21 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
97 lines
3.3 KiB
JavaScript
97 lines
3.3 KiB
JavaScript
import React from 'react';
|
|
import { mount } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import DeleteComponentButton from '../../../../../src/dashboard/components/DeleteComponentButton';
|
|
import EditableTitle from '../../../../../src/components/EditableTitle';
|
|
import HoverMenu from '../../../../../src/dashboard/components/menu/HoverMenu';
|
|
import WithPopoverMenu from '../../../../../src/dashboard/components/menu/WithPopoverMenu';
|
|
import DragDroppable from '../../../../../src/dashboard/components/dnd/DragDroppable';
|
|
import Header from '../../../../../src/dashboard/components/gridComponents/Header';
|
|
import newComponentFactory from '../../../../../src/dashboard/util/newComponentFactory';
|
|
import {
|
|
HEADER_TYPE,
|
|
DASHBOARD_GRID_TYPE,
|
|
} from '../../../../../src/dashboard/util/componentTypes';
|
|
|
|
import WithDragDropContext from '../../helpers/WithDragDropContext';
|
|
|
|
describe('Header', () => {
|
|
const props = {
|
|
id: 'id',
|
|
parentId: 'parentId',
|
|
component: newComponentFactory(HEADER_TYPE),
|
|
depth: 1,
|
|
parentComponent: newComponentFactory(DASHBOARD_GRID_TYPE),
|
|
index: 0,
|
|
editMode: false,
|
|
handleComponentDrop() {},
|
|
deleteComponent() {},
|
|
updateComponents() {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
// We have to wrap provide DragDropContext for the underlying DragDroppable
|
|
// otherwise we cannot assert on DragDroppable children
|
|
const wrapper = mount(
|
|
<WithDragDropContext>
|
|
<Header {...props} {...overrideProps} />
|
|
</WithDragDropContext>,
|
|
);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a DragDroppable', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DragDroppable)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render a WithPopoverMenu', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(WithPopoverMenu)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render a HoverMenu in editMode', () => {
|
|
let wrapper = setup();
|
|
expect(wrapper.find(HoverMenu)).toHaveLength(0);
|
|
|
|
// we cannot set props on the Header because of the WithDragDropContext wrapper
|
|
wrapper = setup({ editMode: true });
|
|
expect(wrapper.find(HoverMenu)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render an EditableTitle with meta.text', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(EditableTitle)).toHaveLength(1);
|
|
expect(wrapper.find('input').prop('value')).toBe(props.component.meta.text);
|
|
});
|
|
|
|
it('should call updateComponents when EditableTitle changes', () => {
|
|
const updateComponents = sinon.spy();
|
|
const wrapper = setup({ editMode: true, updateComponents });
|
|
wrapper.find(EditableTitle).prop('onSaveTitle')('New title');
|
|
|
|
const headerId = props.component.id;
|
|
expect(updateComponents.callCount).toBe(1);
|
|
expect(updateComponents.getCall(0).args[0][headerId].meta.text).toBe(
|
|
'New title',
|
|
);
|
|
});
|
|
|
|
it('should render a DeleteComponentButton when focused in editMode', () => {
|
|
const wrapper = setup({ editMode: true });
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
|
|
expect(wrapper.find(DeleteComponentButton)).toHaveLength(1);
|
|
});
|
|
|
|
it('should call deleteComponent when deleted', () => {
|
|
const deleteComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, deleteComponent });
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
wrapper.find(DeleteComponentButton).simulate('click');
|
|
|
|
expect(deleteComponent.callCount).toBe(1);
|
|
});
|
|
});
|