mirror of
https://github.com/apache/superset.git
synced 2026-04-09 19:35:21 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
125 lines
4.3 KiB
JavaScript
125 lines
4.3 KiB
JavaScript
import { Provider } from 'react-redux';
|
|
import React from 'react';
|
|
import { mount } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import DashboardComponent from '../../../../../src/dashboard/containers/DashboardComponent';
|
|
import DeleteComponentModal from '../../../../../src/dashboard/components/DeleteComponentModal';
|
|
import DragDroppable from '../../../../../src/dashboard/components/dnd/DragDroppable';
|
|
import EditableTitle from '../../../../../src/components/EditableTitle';
|
|
import WithPopoverMenu from '../../../../../src/dashboard/components/menu/WithPopoverMenu';
|
|
import Tab, {
|
|
RENDER_TAB,
|
|
RENDER_TAB_CONTENT,
|
|
} from '../../../../../src/dashboard/components/gridComponents/Tab';
|
|
import WithDragDropContext from '../../helpers/WithDragDropContext';
|
|
import { dashboardLayoutWithTabs } from '../../fixtures/mockDashboardLayout';
|
|
import { mockStoreWithTabs } from '../../fixtures/mockStore';
|
|
|
|
describe('Tabs', () => {
|
|
const props = {
|
|
id: 'TAB_ID',
|
|
parentId: 'TABS_ID',
|
|
component: dashboardLayoutWithTabs.present.TAB_ID,
|
|
parentComponent: dashboardLayoutWithTabs.present.TABS_ID,
|
|
index: 0,
|
|
depth: 1,
|
|
editMode: false,
|
|
renderType: RENDER_TAB,
|
|
onDropOnTab() {},
|
|
onDeleteTab() {},
|
|
availableColumnCount: 12,
|
|
columnWidth: 50,
|
|
onResizeStart() {},
|
|
onResize() {},
|
|
onResizeStop() {},
|
|
createComponent() {},
|
|
handleComponentDrop() {},
|
|
onChangeTab() {},
|
|
deleteComponent() {},
|
|
updateComponents() {},
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
// We have to wrap provide DragDropContext for the underlying DragDroppable
|
|
// otherwise we cannot assert on DragDroppable children
|
|
const wrapper = mount(
|
|
<Provider store={mockStoreWithTabs}>
|
|
<WithDragDropContext>
|
|
<Tab {...props} {...overrideProps} />
|
|
</WithDragDropContext>
|
|
</Provider>,
|
|
);
|
|
return wrapper;
|
|
}
|
|
|
|
describe('renderType=RENDER_TAB', () => {
|
|
it('should render a DragDroppable', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(DragDroppable)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render an EditableTitle with meta.text', () => {
|
|
const wrapper = setup();
|
|
const title = wrapper.find(EditableTitle);
|
|
expect(title).toHaveLength(1);
|
|
expect(title.find('input').prop('value')).toBe(props.component.meta.text);
|
|
});
|
|
|
|
it('should call updateComponents when EditableTitle changes', () => {
|
|
const updateComponents = sinon.spy();
|
|
const wrapper = setup({ editMode: true, updateComponents });
|
|
wrapper.find(EditableTitle).prop('onSaveTitle')('New title');
|
|
|
|
expect(updateComponents.callCount).toBe(1);
|
|
expect(updateComponents.getCall(0).args[0].TAB_ID.meta.text).toBe(
|
|
'New title',
|
|
);
|
|
});
|
|
|
|
it('should render a WithPopoverMenu', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(WithPopoverMenu)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render a DeleteComponentModal when focused if its not the only tab', () => {
|
|
let wrapper = setup();
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
expect(wrapper.find(DeleteComponentModal)).toHaveLength(0);
|
|
|
|
wrapper = setup({ editMode: true });
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).toHaveLength(1);
|
|
|
|
wrapper = setup({
|
|
editMode: true,
|
|
parentComponent: {
|
|
...props.parentComponent,
|
|
children: props.parentComponent.children.slice(0, 1),
|
|
},
|
|
});
|
|
wrapper.find(WithPopoverMenu).simulate('click');
|
|
expect(wrapper.find(DeleteComponentModal)).toHaveLength(0);
|
|
});
|
|
|
|
it('should show modal when clicked delete icon', () => {
|
|
const deleteComponent = sinon.spy();
|
|
const wrapper = setup({ editMode: true, deleteComponent });
|
|
wrapper.find(WithPopoverMenu).simulate('click'); // focus
|
|
wrapper.find('.icon-button').simulate('click');
|
|
|
|
const modal = document.getElementsByClassName('modal');
|
|
expect(modal).toHaveLength(1);
|
|
expect(deleteComponent.callCount).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe('renderType=RENDER_TAB_CONTENT', () => {
|
|
it('should render a DashboardComponent', () => {
|
|
const wrapper = setup({ renderType: RENDER_TAB_CONTENT });
|
|
// We expect 2 because this Tab has a Row child and the row has a Chart
|
|
expect(wrapper.find(DashboardComponent)).toHaveLength(2);
|
|
});
|
|
});
|
|
});
|