Files
superset2/superset/assets/spec/javascripts/dashboard/reducers/dashboardState_spec.js
Christine Chambers 9029701f24 [refactor] Migrate from Mocha+Chai to Jest (#6079)
* [refactor] Migrate from Mocha+Chai to Jest

This change migrates all the existing unit tests
- to Jest's global expect and matchers from chai's imported expect, asserts and matchers.
- to Jest's describe/test from mocha's describe/it

The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks:
1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank.
2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :)

This change also removes dependencies to Mocha and Chai.

* Remove the test:one command as it now does the same thing as test.

* Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix`

The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest.

* Adding eslint-plugin-jest and further modify tests.

- One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing.
- Deletion of a duplicated test caught by eslint-plugin-jest.

* - Make istanbul coverage work with Jest.

- Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes!

* Attempt to fix dynamic imports in tests.

* run sequentially and log heap usage

* - tweaking maxworkers for travis and specifying coverageDirectory for codecov

- remove dynamic import in shim.js now that it is set in babelrc for tests only.
2018-10-15 13:10:18 -07:00

238 lines
5.8 KiB
JavaScript

import {
ADD_SLICE,
CHANGE_FILTER,
ON_CHANGE,
ON_SAVE,
REMOVE_SLICE,
SET_EDIT_MODE,
SET_MAX_UNDO_HISTORY_EXCEEDED,
SET_UNSAVED_CHANGES,
TOGGLE_BUILDER_PANE,
TOGGLE_EXPAND_SLICE,
TOGGLE_FAVE_STAR,
} from '../../../../src/dashboard/actions/dashboardState';
import dashboardStateReducer from '../../../../src/dashboard/reducers/dashboardState';
describe('dashboardState reducer', () => {
it('should return initial state', () => {
expect(dashboardStateReducer(undefined, {})).toEqual({});
});
it('should add a slice', () => {
expect(
dashboardStateReducer(
{ sliceIds: [1] },
{ type: ADD_SLICE, slice: { slice_id: 2 } },
),
).toEqual({ sliceIds: [1, 2] });
});
it('should remove a slice', () => {
expect(
dashboardStateReducer(
{ sliceIds: [1, 2], filters: {} },
{ type: REMOVE_SLICE, sliceId: 2 },
),
).toEqual({ sliceIds: [1], refresh: false, filters: {} });
});
it('should reset filters if a removed slice is a filter', () => {
expect(
dashboardStateReducer(
{ sliceIds: [1, 2], filters: { 2: {}, 1: {} } },
{ type: REMOVE_SLICE, sliceId: 2 },
),
).toEqual({ sliceIds: [1], filters: { 1: {} }, refresh: true });
});
it('should toggle fav star', () => {
expect(
dashboardStateReducer(
{ isStarred: false },
{ type: TOGGLE_FAVE_STAR, isStarred: true },
),
).toEqual({ isStarred: true });
});
it('should toggle edit mode', () => {
expect(
dashboardStateReducer(
{ editMode: false },
{ type: SET_EDIT_MODE, editMode: true },
),
).toEqual({ editMode: true, showBuilderPane: true });
});
it('should toggle builder pane', () => {
expect(
dashboardStateReducer(
{ showBuilderPane: false },
{ type: TOGGLE_BUILDER_PANE },
),
).toEqual({ showBuilderPane: true });
expect(
dashboardStateReducer(
{ showBuilderPane: true },
{ type: TOGGLE_BUILDER_PANE },
),
).toEqual({ showBuilderPane: false });
});
it('should toggle expanded slices', () => {
expect(
dashboardStateReducer(
{ expandedSlices: { 1: true, 2: false } },
{ type: TOGGLE_EXPAND_SLICE, sliceId: 1 },
),
).toEqual({ expandedSlices: { 2: false } });
expect(
dashboardStateReducer(
{ expandedSlices: { 1: true, 2: false } },
{ type: TOGGLE_EXPAND_SLICE, sliceId: 2 },
),
).toEqual({ expandedSlices: { 1: true, 2: true } });
});
it('should set hasUnsavedChanges', () => {
expect(dashboardStateReducer({}, { type: ON_CHANGE })).toEqual({
hasUnsavedChanges: true,
});
expect(
dashboardStateReducer(
{},
{ type: SET_UNSAVED_CHANGES, payload: { hasUnsavedChanges: false } },
),
).toEqual({
hasUnsavedChanges: false,
});
});
it('should set maxUndoHistoryExceeded', () => {
expect(
dashboardStateReducer(
{},
{
type: SET_MAX_UNDO_HISTORY_EXCEEDED,
payload: { maxUndoHistoryExceeded: true },
},
),
).toEqual({
maxUndoHistoryExceeded: true,
});
});
it('should set unsaved changes, max undo history, and editMode to false on save', () => {
expect(
dashboardStateReducer({ hasUnsavedChanges: true }, { type: ON_SAVE }),
).toEqual({
hasUnsavedChanges: false,
maxUndoHistoryExceeded: false,
editMode: false,
});
});
describe('change filter', () => {
it('should add a new filter if it does not exist', () => {
expect(
dashboardStateReducer(
{
filters: {},
sliceIds: [1],
},
{
type: CHANGE_FILTER,
chart: { id: 1, formData: { groupby: 'column' } },
col: 'column',
vals: ['b', 'a'],
refresh: true,
merge: true,
},
),
).toEqual({
filters: { 1: { column: ['b', 'a'] } },
refresh: true,
sliceIds: [1],
});
});
it('should overwrite a filter if merge is false', () => {
expect(
dashboardStateReducer(
{
filters: {
1: { column: ['z'] },
},
sliceIds: [1],
},
{
type: CHANGE_FILTER,
chart: { id: 1, formData: { groupby: 'column' } },
col: 'column',
vals: ['b', 'a'],
refresh: true,
merge: false,
},
),
).toEqual({
filters: { 1: { column: ['b', 'a'] } },
refresh: true,
sliceIds: [1],
});
});
it('should merge a filter if merge is true', () => {
expect(
dashboardStateReducer(
{
filters: {
1: { column: ['z'] },
},
sliceIds: [1],
},
{
type: CHANGE_FILTER,
chart: { id: 1, formData: { groupby: 'column' } },
col: 'column',
vals: ['b', 'a'],
refresh: true,
merge: true,
},
),
).toEqual({
filters: { 1: { column: ['z', 'b', 'a'] } },
refresh: true,
sliceIds: [1],
});
});
it('should remove the filter if values are empty', () => {
expect(
dashboardStateReducer(
{
filters: {
1: { column: ['z'] },
},
sliceIds: [1],
},
{
type: CHANGE_FILTER,
chart: { id: 1, formData: { groupby: 'column' } },
col: 'column',
vals: [],
refresh: true,
merge: false,
},
),
).toEqual({
filters: {},
refresh: true,
sliceIds: [1],
});
});
});
});