mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
225 lines
4.7 KiB
JavaScript
225 lines
4.7 KiB
JavaScript
import dropOverflowsParent from '../../../../src/dashboard/util/dropOverflowsParent';
|
|
import { NEW_COMPONENTS_SOURCE_ID } from '../../../../src/dashboard/util/constants';
|
|
import {
|
|
CHART_TYPE,
|
|
COLUMN_TYPE,
|
|
ROW_TYPE,
|
|
HEADER_TYPE,
|
|
TAB_TYPE,
|
|
} from '../../../../src/dashboard/util/componentTypes';
|
|
|
|
describe('dropOverflowsParent', () => {
|
|
it('returns true if a parent does NOT have adequate width for child', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'a' },
|
|
dragging: { id: 'z' },
|
|
};
|
|
|
|
const layout = {
|
|
a: {
|
|
id: 'a',
|
|
type: ROW_TYPE,
|
|
children: ['b', 'b', 'b', 'b'], // width = 4x bs = 12
|
|
},
|
|
b: {
|
|
id: 'b',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 3,
|
|
},
|
|
},
|
|
z: {
|
|
id: 'z',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 2,
|
|
},
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(true);
|
|
});
|
|
|
|
it('returns false if a parent DOES have adequate width for child', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'a' },
|
|
dragging: { id: 'z' },
|
|
};
|
|
|
|
const layout = {
|
|
a: {
|
|
id: 'a',
|
|
type: ROW_TYPE,
|
|
children: ['b', 'b'],
|
|
},
|
|
b: {
|
|
id: 'b',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 3,
|
|
},
|
|
},
|
|
z: {
|
|
id: 'z',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 2,
|
|
},
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(false);
|
|
});
|
|
|
|
it('returns false if a child CAN shrink to available parent space', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'a' },
|
|
dragging: { id: 'z' },
|
|
};
|
|
|
|
const layout = {
|
|
a: {
|
|
id: 'a',
|
|
type: ROW_TYPE,
|
|
children: ['b', 'b'], // 2x b = 10
|
|
},
|
|
b: {
|
|
id: 'b',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 5,
|
|
},
|
|
},
|
|
z: {
|
|
id: 'z',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 10,
|
|
},
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(false);
|
|
});
|
|
|
|
it('returns true if a child CANNOT shrink to available parent space', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'a' },
|
|
dragging: { id: 'b' },
|
|
};
|
|
|
|
const layout = {
|
|
a: {
|
|
id: 'a',
|
|
type: COLUMN_TYPE,
|
|
meta: {
|
|
width: 6,
|
|
},
|
|
},
|
|
// rows with children cannot shrink
|
|
b: {
|
|
id: 'b',
|
|
type: ROW_TYPE,
|
|
children: ['bChild', 'bChild', 'bChild'],
|
|
},
|
|
bChild: {
|
|
id: 'bChild',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 3,
|
|
},
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(true);
|
|
});
|
|
|
|
it('returns true if a column has children that CANNOT shrink to available parent space', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'destination' },
|
|
dragging: { id: 'dragging' },
|
|
};
|
|
|
|
const layout = {
|
|
destination: {
|
|
id: 'destination',
|
|
type: ROW_TYPE,
|
|
children: ['b', 'b'], // 2x b = 10, 2 available
|
|
},
|
|
b: {
|
|
id: 'b',
|
|
type: CHART_TYPE,
|
|
meta: {
|
|
width: 5,
|
|
},
|
|
},
|
|
dragging: {
|
|
id: 'dragging',
|
|
type: COLUMN_TYPE,
|
|
meta: {
|
|
width: 10,
|
|
},
|
|
children: ['rowWithChildren'], // 2x b = width 10
|
|
},
|
|
rowWithChildren: {
|
|
id: 'rowWithChildren',
|
|
type: ROW_TYPE,
|
|
children: ['b', 'b'],
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(true);
|
|
// remove children
|
|
expect(
|
|
dropOverflowsParent(dropResult, {
|
|
...layout,
|
|
dragging: { ...layout.dragging, children: [] },
|
|
}),
|
|
).toBe(false);
|
|
});
|
|
|
|
it('should work with new components that are not in the layout', () => {
|
|
const dropResult = {
|
|
source: { id: NEW_COMPONENTS_SOURCE_ID },
|
|
destination: { id: 'a' },
|
|
dragging: { type: CHART_TYPE },
|
|
};
|
|
|
|
const layout = {
|
|
a: {
|
|
id: 'a',
|
|
type: ROW_TYPE,
|
|
children: [],
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(false);
|
|
});
|
|
|
|
it('source/destination without widths should not overflow parent', () => {
|
|
const dropResult = {
|
|
source: { id: '_' },
|
|
destination: { id: 'tab' },
|
|
dragging: { id: 'header' },
|
|
};
|
|
|
|
const layout = {
|
|
tab: {
|
|
id: 'tab',
|
|
type: TAB_TYPE,
|
|
},
|
|
header: {
|
|
id: 'header',
|
|
type: HEADER_TYPE,
|
|
},
|
|
};
|
|
|
|
expect(dropOverflowsParent(dropResult, layout)).toBe(false);
|
|
});
|
|
});
|