mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
223 lines
6.4 KiB
JavaScript
223 lines
6.4 KiB
JavaScript
import getDetailedComponentWidth from '../../../../src/dashboard/util/getDetailedComponentWidth';
|
|
import * as types from '../../../../src/dashboard/util/componentTypes';
|
|
import {
|
|
GRID_COLUMN_COUNT,
|
|
GRID_MIN_COLUMN_COUNT,
|
|
} from '../../../../src/dashboard/util/constants';
|
|
|
|
describe('getDetailedComponentWidth', () => {
|
|
it('should return an object with width, minimumWidth, and occupiedWidth', () => {
|
|
expect(
|
|
Object.keys(getDetailedComponentWidth({ id: '_', components: {} })),
|
|
).toEqual(
|
|
expect.arrayContaining(['minimumWidth', 'occupiedWidth', 'width']),
|
|
);
|
|
});
|
|
|
|
describe('width', () => {
|
|
it('should be undefined if the component is not resizable and has no defined width', () => {
|
|
const empty = {
|
|
width: undefined,
|
|
occupiedWidth: undefined,
|
|
minimumWidth: undefined,
|
|
};
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.HEADER_TYPE },
|
|
}),
|
|
).toEqual(empty);
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.DIVIDER_TYPE },
|
|
}),
|
|
).toEqual(empty);
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.TAB_TYPE },
|
|
}),
|
|
).toEqual(empty);
|
|
});
|
|
|
|
it('should match component meta width for resizeable components', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.CHART_TYPE, meta: { width: 1 } },
|
|
}),
|
|
).toEqual({ width: 1, occupiedWidth: 1, minimumWidth: 1 });
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.MARKDOWN_TYPE, meta: { width: 2 } },
|
|
}),
|
|
).toEqual({ width: 2, occupiedWidth: 2, minimumWidth: 1 });
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.COLUMN_TYPE, meta: { width: 3 } },
|
|
}),
|
|
// note: occupiedWidth is zero for colunns/see test below
|
|
).toEqual({ width: 3, occupiedWidth: 0, minimumWidth: 1 });
|
|
});
|
|
|
|
it('should be GRID_COLUMN_COUNT for row components WITHOUT parents', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'row',
|
|
components: { row: { id: 'row', type: types.ROW_TYPE } },
|
|
}),
|
|
).toEqual({
|
|
width: GRID_COLUMN_COUNT,
|
|
occupiedWidth: 0,
|
|
minimumWidth: GRID_MIN_COLUMN_COUNT,
|
|
});
|
|
});
|
|
|
|
it('should match parent width for row components WITH parents', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'row',
|
|
components: {
|
|
row: { id: 'row', type: types.ROW_TYPE },
|
|
parent: {
|
|
id: 'parent',
|
|
type: types.COLUMN_TYPE,
|
|
children: ['row'],
|
|
meta: { width: 7 },
|
|
},
|
|
},
|
|
}),
|
|
).toEqual({
|
|
width: 7,
|
|
occupiedWidth: 0,
|
|
minimumWidth: GRID_MIN_COLUMN_COUNT,
|
|
});
|
|
});
|
|
|
|
it('should use either id or component (to support new components)', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'id',
|
|
components: {
|
|
id: { id: 'id', type: types.CHART_TYPE, meta: { width: 6 } },
|
|
},
|
|
}).width,
|
|
).toBe(6);
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: 'id', type: types.CHART_TYPE, meta: { width: 6 } },
|
|
}).width,
|
|
).toBe(6);
|
|
});
|
|
});
|
|
|
|
describe('occupiedWidth', () => {
|
|
it('should reflect the sum of child widths for row components', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'row',
|
|
components: {
|
|
row: {
|
|
id: 'row',
|
|
type: types.ROW_TYPE,
|
|
children: ['child', 'child'],
|
|
},
|
|
child: { id: 'child', meta: { width: 3.5 } },
|
|
},
|
|
}),
|
|
).toEqual({ width: 12, occupiedWidth: 7, minimumWidth: 7 });
|
|
});
|
|
|
|
it('should always be zero for column components', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.COLUMN_TYPE, meta: { width: 2 } },
|
|
}),
|
|
).toEqual({ width: 2, occupiedWidth: 0, minimumWidth: 1 });
|
|
});
|
|
});
|
|
|
|
describe('minimumWidth', () => {
|
|
it('should equal GRID_MIN_COLUMN_COUNT for resizable components', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.CHART_TYPE, meta: { width: 1 } },
|
|
}),
|
|
).toEqual({
|
|
width: 1,
|
|
minimumWidth: GRID_MIN_COLUMN_COUNT,
|
|
occupiedWidth: 1,
|
|
});
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.MARKDOWN_TYPE, meta: { width: 2 } },
|
|
}),
|
|
).toEqual({
|
|
width: 2,
|
|
minimumWidth: GRID_MIN_COLUMN_COUNT,
|
|
occupiedWidth: 2,
|
|
});
|
|
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
component: { id: '', type: types.COLUMN_TYPE, meta: { width: 3 } },
|
|
}),
|
|
).toEqual({
|
|
width: 3,
|
|
minimumWidth: GRID_MIN_COLUMN_COUNT,
|
|
occupiedWidth: 0,
|
|
});
|
|
});
|
|
|
|
it('should equal the width of row children for column components with row children', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'column',
|
|
components: {
|
|
column: {
|
|
id: 'column',
|
|
type: types.COLUMN_TYPE,
|
|
children: ['rowChild', 'ignoredChartChild'],
|
|
meta: { width: 12 },
|
|
},
|
|
rowChild: {
|
|
id: 'rowChild',
|
|
type: types.ROW_TYPE,
|
|
children: ['rowChildChild', 'rowChildChild'],
|
|
},
|
|
rowChildChild: {
|
|
id: 'rowChildChild',
|
|
meta: { width: 3.5 },
|
|
},
|
|
ignoredChartChild: {
|
|
id: 'ignoredChartChild',
|
|
meta: { width: 100 },
|
|
},
|
|
},
|
|
}),
|
|
// occupiedWidth is zero for colunns/see test below
|
|
).toEqual({ width: 12, occupiedWidth: 0, minimumWidth: 7 });
|
|
});
|
|
|
|
it('should equal occupiedWidth for row components', () => {
|
|
expect(
|
|
getDetailedComponentWidth({
|
|
id: 'row',
|
|
components: {
|
|
row: {
|
|
id: 'row',
|
|
type: types.ROW_TYPE,
|
|
children: ['child', 'child'],
|
|
},
|
|
child: { id: 'child', meta: { width: 3.5 } },
|
|
},
|
|
}),
|
|
).toEqual({ width: 12, occupiedWidth: 7, minimumWidth: 7 });
|
|
});
|
|
});
|
|
});
|