mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
49 lines
1.1 KiB
JavaScript
49 lines
1.1 KiB
JavaScript
import newComponentFactory from '../../../../src/dashboard/util/newComponentFactory';
|
|
|
|
import {
|
|
CHART_TYPE,
|
|
COLUMN_TYPE,
|
|
DASHBOARD_GRID_TYPE,
|
|
DASHBOARD_ROOT_TYPE,
|
|
DIVIDER_TYPE,
|
|
HEADER_TYPE,
|
|
MARKDOWN_TYPE,
|
|
NEW_COMPONENT_SOURCE_TYPE,
|
|
ROW_TYPE,
|
|
TABS_TYPE,
|
|
TAB_TYPE,
|
|
} from '../../../../src/dashboard/util/componentTypes';
|
|
|
|
const types = [
|
|
CHART_TYPE,
|
|
COLUMN_TYPE,
|
|
DASHBOARD_GRID_TYPE,
|
|
DASHBOARD_ROOT_TYPE,
|
|
DIVIDER_TYPE,
|
|
HEADER_TYPE,
|
|
MARKDOWN_TYPE,
|
|
NEW_COMPONENT_SOURCE_TYPE,
|
|
ROW_TYPE,
|
|
TABS_TYPE,
|
|
TAB_TYPE,
|
|
];
|
|
|
|
describe('newEntityFactory', () => {
|
|
types.forEach(type => {
|
|
it(`returns a new ${type}`, () => {
|
|
const result = newComponentFactory(type);
|
|
|
|
expect(result.type).toBe(type);
|
|
expect(typeof result.id).toBe('string');
|
|
expect(typeof result.meta).toBe('object');
|
|
expect(Array.isArray(result.children)).toBe(true);
|
|
});
|
|
});
|
|
|
|
it('adds passed meta data to the entity', () => {
|
|
const banana = 'banana';
|
|
const result = newComponentFactory(CHART_TYPE, { banana });
|
|
expect(result.meta.banana).toBe(banana);
|
|
});
|
|
});
|