mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
83 lines
2.3 KiB
JavaScript
83 lines
2.3 KiB
JavaScript
import newEntitiesFromDrop from '../../../../src/dashboard/util/newEntitiesFromDrop';
|
|
import {
|
|
CHART_TYPE,
|
|
DASHBOARD_GRID_TYPE,
|
|
ROW_TYPE,
|
|
TABS_TYPE,
|
|
TAB_TYPE,
|
|
} from '../../../../src/dashboard/util/componentTypes';
|
|
|
|
describe('newEntitiesFromDrop', () => {
|
|
it('should return a new Entity of appropriate type, and add it to the drop target children', () => {
|
|
const result = newEntitiesFromDrop({
|
|
dropResult: {
|
|
destination: { id: 'a', index: 0 },
|
|
dragging: { type: CHART_TYPE },
|
|
source: { id: 'b', index: 0 },
|
|
},
|
|
layout: {
|
|
a: {
|
|
id: 'a',
|
|
type: ROW_TYPE,
|
|
children: [],
|
|
},
|
|
},
|
|
});
|
|
|
|
const newId = result.a.children[0];
|
|
expect(result.a.children).toHaveLength(1);
|
|
expect(Object.keys(result)).toHaveLength(2);
|
|
expect(result[newId].type).toBe(CHART_TYPE);
|
|
});
|
|
|
|
it('should create Tab AND Tabs components if the drag entity is Tabs', () => {
|
|
const result = newEntitiesFromDrop({
|
|
dropResult: {
|
|
destination: { id: 'a', index: 0 },
|
|
dragging: { type: TABS_TYPE },
|
|
source: { id: 'b', index: 0 },
|
|
},
|
|
layout: {
|
|
a: {
|
|
id: 'a',
|
|
type: DASHBOARD_GRID_TYPE,
|
|
children: [],
|
|
},
|
|
},
|
|
});
|
|
|
|
const newTabsId = result.a.children[0];
|
|
const newTabId = result[newTabsId].children[0];
|
|
|
|
expect(result.a.children).toHaveLength(1);
|
|
expect(Object.keys(result)).toHaveLength(3);
|
|
expect(result[newTabsId].type).toBe(TABS_TYPE);
|
|
expect(result[newTabId].type).toBe(TAB_TYPE);
|
|
});
|
|
|
|
it('should create a Row if the drag entity should be wrapped in a row', () => {
|
|
const result = newEntitiesFromDrop({
|
|
dropResult: {
|
|
destination: { id: 'a', index: 0 },
|
|
dragging: { type: CHART_TYPE },
|
|
source: { id: 'b', index: 0 },
|
|
},
|
|
layout: {
|
|
a: {
|
|
id: 'a',
|
|
type: DASHBOARD_GRID_TYPE,
|
|
children: [],
|
|
},
|
|
},
|
|
});
|
|
|
|
const newRowId = result.a.children[0];
|
|
const newChartId = result[newRowId].children[0];
|
|
|
|
expect(result.a.children).toHaveLength(1);
|
|
expect(Object.keys(result)).toHaveLength(3);
|
|
expect(result[newRowId].type).toBe(ROW_TYPE);
|
|
expect(result[newChartId].type).toBe(CHART_TYPE);
|
|
});
|
|
});
|