mirror of
https://github.com/apache/superset.git
synced 2026-04-09 03:16:07 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
91 lines
3.1 KiB
JavaScript
91 lines
3.1 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import EditableTable from '../../../src/components/EditableTitle';
|
|
|
|
describe('EditableTitle', () => {
|
|
const callback = sinon.spy();
|
|
const mockProps = {
|
|
title: 'my title',
|
|
canEdit: true,
|
|
onSaveTitle: callback,
|
|
};
|
|
const mockEvent = {
|
|
target: {
|
|
value: 'new title',
|
|
},
|
|
};
|
|
const editableWrapper = shallow(<EditableTable {...mockProps} />);
|
|
const notEditableWrapper = shallow(<EditableTable title="my title" onSaveTitle={callback} />);
|
|
it('is valid', () => {
|
|
expect(
|
|
React.isValidElement(<EditableTable {...mockProps} />),
|
|
).toBe(true);
|
|
});
|
|
it('should render title', () => {
|
|
const titleElement = editableWrapper.find('input');
|
|
expect(titleElement.props().value).toBe('my title');
|
|
expect(titleElement.props().type).toBe('button');
|
|
});
|
|
|
|
describe('should handle click', () => {
|
|
it('should change title', () => {
|
|
editableWrapper.find('input').simulate('click');
|
|
expect(editableWrapper.find('input').props().type).toBe('text');
|
|
});
|
|
it('should not change title', () => {
|
|
notEditableWrapper.find('input').simulate('click');
|
|
expect(notEditableWrapper.find('input').props().type).toBe('button');
|
|
});
|
|
});
|
|
|
|
describe('should handle change', () => {
|
|
afterEach(() => {
|
|
editableWrapper.setState({ title: 'my title' });
|
|
editableWrapper.setState({ lastTitle: 'my title' });
|
|
});
|
|
it('should change title', () => {
|
|
editableWrapper.find('input').simulate('change', mockEvent);
|
|
expect(editableWrapper.find('input').props().value).toBe('new title');
|
|
});
|
|
it('should not change title', () => {
|
|
notEditableWrapper.find('input').simulate('change', mockEvent);
|
|
expect(editableWrapper.find('input').props().value).toBe('my title');
|
|
});
|
|
});
|
|
|
|
describe('should handle blur', () => {
|
|
beforeEach(() => {
|
|
editableWrapper.find('input').simulate('click');
|
|
expect(editableWrapper.find('input').props().type).toBe('text');
|
|
});
|
|
afterEach(() => {
|
|
callback.reset();
|
|
editableWrapper.setState({ title: 'my title' });
|
|
editableWrapper.setState({ lastTitle: 'my title' });
|
|
});
|
|
|
|
it('should trigger callback', () => {
|
|
editableWrapper.setState({ title: 'new title' });
|
|
editableWrapper.find('input').simulate('blur');
|
|
expect(editableWrapper.find('input').props().type).toBe('button');
|
|
expect(callback.callCount).toBe(1);
|
|
expect(callback.getCall(0).args[0]).toBe('new title');
|
|
});
|
|
it('should not trigger callback', () => {
|
|
editableWrapper.find('input').simulate('blur');
|
|
expect(editableWrapper.find('input').props().type).toBe('button');
|
|
// no change
|
|
expect(callback.callCount).toBe(0);
|
|
});
|
|
it('should not save empty title', () => {
|
|
editableWrapper.setState({ title: '' });
|
|
editableWrapper.find('input').simulate('blur');
|
|
expect(editableWrapper.find('input').props().type).toBe('button');
|
|
expect(editableWrapper.find('input').props().value).toBe('my title');
|
|
expect(callback.callCount).toBe(0);
|
|
});
|
|
});
|
|
});
|