mirror of
https://github.com/apache/superset.git
synced 2026-04-11 04:15:33 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
58 lines
1.6 KiB
JavaScript
58 lines
1.6 KiB
JavaScript
import React from 'react';
|
|
import { mount } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import Timer from '../../../src/components/Timer';
|
|
import { now } from '../../../src/modules/dates';
|
|
|
|
describe('Timer', () => {
|
|
let wrapper;
|
|
let clock;
|
|
const mockedProps = {
|
|
endTime: null,
|
|
isRunning: true,
|
|
status: 'warning',
|
|
};
|
|
|
|
beforeEach(() => {
|
|
clock = sinon.useFakeTimers();
|
|
mockedProps.startTime = now() + 1;
|
|
wrapper = mount(<Timer {...mockedProps} />);
|
|
});
|
|
afterEach(() => {
|
|
clock.restore();
|
|
});
|
|
|
|
it('is a valid element', () => {
|
|
expect(React.isValidElement(<Timer {...mockedProps} />)).toBe(true);
|
|
});
|
|
|
|
it('componentWillMount starts timer after 30ms and sets state.clockStr', () => {
|
|
expect(wrapper.state().clockStr).toBe('');
|
|
clock.tick(31);
|
|
expect(wrapper.state().clockStr).not.toBe('');
|
|
});
|
|
|
|
it('calls startTimer on mount', () => {
|
|
// Timer is already mounted in beforeEach
|
|
wrapper.unmount();
|
|
const startTimerSpy = sinon.spy(Timer.prototype, 'startTimer');
|
|
wrapper.mount();
|
|
// Timer is started once in willUnmount and a second timer in render
|
|
// TODO: Questionable whether this is necessary.
|
|
expect(startTimerSpy.callCount).toBe(2);
|
|
startTimerSpy.restore();
|
|
});
|
|
|
|
it('calls stopTimer on unmount', () => {
|
|
const stopTimerSpy = sinon.spy(Timer.prototype, 'stopTimer');
|
|
wrapper.unmount();
|
|
expect(stopTimerSpy.callCount).toBe(1);
|
|
stopTimerSpy.restore();
|
|
});
|
|
|
|
it('renders a span with the correct class', () => {
|
|
expect(wrapper.find('span').hasClass('label-warning')).toBe(true);
|
|
});
|
|
});
|