mirror of
https://github.com/apache/superset.git
synced 2026-07-10 16:55:30 +00:00
af5eca38f5
Remove the extension admin-settings layer entirely. With the Extensions admin page and the settings write path already gone, the only remaining use of GET /api/v1/extensions/settings was reading active_chatbot_id — a pin nothing in the product could set (DB-only). Rather than keep a read endpoint for an unsettable value, drop the whole layer and resolve the active chatbot purely from the view registry: the most-recently-registered (last-loaded) chatbot wins. Frontend: - getActiveChatbot() takes no args and returns the last-registered chatbot at superset.chatbot (was: first-registered + optional admin pin). - ChatbotMount resolves from the view registry alone — no settings fetch, no loading gate, no settings store subscription. - Remove the settings store from core/extensions (ExtensionSettings type, SETTINGS_ENDPOINT, load/subscribe/snapshot); keep the extensions namespace. Backend: - Remove GET /settings route + can_get_settings permission from the API. - Delete the settings command package, ExtensionSettingsDAO/get_extension_settings, and the ExtensionSettings model; drop its registration import. - Migration e2f3a4b5c6d7 drops the extension_settings table (reversible). Behavior change: there is no admin chatbot pin anymore. When multiple chatbot extensions load, the last one to register takes the singleton bubble. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>