mirror of
https://github.com/apache/superset.git
synced 2026-08-31 04:21:16 +00:00
Superset Dev
889d2a6a22
Stacked on feat/testcontainers-more-dialects. All four extras already existed in pyproject.toml, so this only wires up tests -- no new optional-dependency groups needed. - postgres/mysql: straight copies of the timescaledb/mariadb pattern respectively, pointed at vanilla images instead of a fork/extension. - clickhouse: connects over the container's HTTP port (8123), matching clickhouse-connect (Superset's driver), not the native TCP port (9000) the container's own docstring example uses. ClickHouse has no real primary-key concept and clickhouse-connect's DDL compiler rejects CREATE TABLE without an explicit engine, so _pagination.py gained an optional extra_table_args hook to pass MergeTree(order_by=...). Also works around a pre-existing quirk in db_engine_specs/clickhouse.py: its module-level type-formatting setup dereferences current_app.config, so importing it outside a Flask app context raises RuntimeError -- tests/unit_tests/db_engine_specs/test_clickhouse.py already works around this with per-test local imports, but that suite also benefits from an autouse app_context fixture this suite doesn't have, so this test pushes one explicitly around the one-time import. - starrocks: no dedicated testcontainers module, so a generic DockerContainer against the official allin1-ubuntu image (FE+BE in one container). Not verified locally (multiple-GB image, skipped to keep local Docker load low per session guidance); the fixture retries its first connection since the query port can accept TCP before StarRocks' query engine is fully initialized.
100 lines
3.5 KiB
Python
100 lines
3.5 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
"""
|
|
Tests db_engine_specs.postgres against a real PostgreSQL instance, spun up
|
|
on demand via testcontainers. Run via .github/workflows/testcontainers.yml
|
|
-- these exercise real SQL execution and dialect introspection, which
|
|
mocked unit tests structurally cannot.
|
|
|
|
Plain Postgres itself was never covered by this suite: CockroachDB,
|
|
TimescaleDB and YugabyteDB all speak the Postgres wire protocol and already
|
|
exercise `PostgresContainer`/the "postgresql" dialect, but none of them
|
|
stand in for vanilla PostgreSQL's own dialect quirks.
|
|
"""
|
|
|
|
from collections.abc import Iterator
|
|
|
|
import pytest
|
|
from sqlalchemy import (
|
|
Column,
|
|
create_engine,
|
|
inspect,
|
|
Integer,
|
|
MetaData,
|
|
Table as SATable,
|
|
)
|
|
from sqlalchemy.engine import Engine
|
|
|
|
from superset.db_engine_specs.postgres import PostgresEngineSpec
|
|
from superset.sql.parse import Table
|
|
from superset.utils.core import GenericDataType
|
|
|
|
pytestmark = pytest.mark.testcontainers
|
|
|
|
from ._driver import require_driver # noqa: E402
|
|
|
|
require_driver("testcontainers.community.postgres")
|
|
|
|
from testcontainers.community.postgres import PostgresContainer # noqa: E402
|
|
|
|
from ._pagination import ( # noqa: E402
|
|
assert_paginated_query_returns_correct_rows_in_order,
|
|
)
|
|
|
|
|
|
@pytest.fixture(scope="module")
|
|
def engine() -> Iterator[Engine]:
|
|
with PostgresContainer("postgres:17-alpine") as container:
|
|
yield create_engine(container.get_connection_url())
|
|
|
|
|
|
def test_paginated_query_returns_correct_rows_in_order(engine: Engine) -> None:
|
|
"""
|
|
A plain SQLAlchemy Core LIMIT/OFFSET query, compiled and executed against
|
|
a real instance. Mocked tests cannot catch a dialect compiling this
|
|
incorrectly (see apache/superset#42899, where Trino emitted OFFSET
|
|
before LIMIT) -- only real execution can.
|
|
"""
|
|
assert_paginated_query_returns_correct_rows_in_order(engine)
|
|
|
|
|
|
def test_get_columns_maps_native_types(engine: Engine) -> None:
|
|
"""
|
|
PostgresEngineSpec.get_columns wraps a real SQLAlchemy Inspector; this
|
|
exercises that against actual server-reported column metadata rather
|
|
than a mocked Inspector.
|
|
"""
|
|
metadata = MetaData()
|
|
SATable(
|
|
"pilot_types",
|
|
metadata,
|
|
Column("id", Integer, primary_key=True),
|
|
Column("amount", Integer),
|
|
)
|
|
metadata.create_all(engine)
|
|
|
|
inspector = inspect(engine)
|
|
columns = PostgresEngineSpec.get_columns(inspector, Table("pilot_types"))
|
|
|
|
by_name = {col["column_name"]: col for col in columns}
|
|
assert set(by_name) == {"id", "amount"}
|
|
for col in by_name.values():
|
|
spec = PostgresEngineSpec.get_column_spec(str(col["type"]))
|
|
assert spec is not None
|
|
assert spec.generic_type == GenericDataType.NUMERIC
|
|
assert isinstance(spec.sqla_type, Integer)
|