mirror of
https://github.com/apache/superset.git
synced 2026-04-11 12:26:05 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
88 lines
2.6 KiB
JavaScript
88 lines
2.6 KiB
JavaScript
import React from 'react';
|
|
import { shallow } from 'enzyme';
|
|
import sinon from 'sinon';
|
|
|
|
import Chart from '../../../../../src/dashboard/components/gridComponents/Chart';
|
|
import SliceHeader from '../../../../../src/dashboard/components/SliceHeader';
|
|
import ChartContainer from '../../../../../src/chart/ChartContainer';
|
|
|
|
import mockDatasource from '../../../../fixtures/mockDatasource';
|
|
import {
|
|
sliceEntitiesForChart as sliceEntities,
|
|
sliceId,
|
|
} from '../../fixtures/mockSliceEntities';
|
|
import chartQueries, {
|
|
sliceId as queryId,
|
|
} from '../../fixtures/mockChartQueries';
|
|
|
|
describe('Chart', () => {
|
|
const props = {
|
|
id: sliceId,
|
|
width: 100,
|
|
height: 100,
|
|
updateSliceName() {},
|
|
|
|
// from redux
|
|
chart: chartQueries[queryId],
|
|
formData: chartQueries[queryId].formData,
|
|
datasource: mockDatasource[sliceEntities.slices[sliceId].datasource],
|
|
slice: {
|
|
...sliceEntities.slices[sliceId],
|
|
description_markeddown: 'markdown',
|
|
},
|
|
sliceName: sliceEntities.slices[sliceId].slice_name,
|
|
timeout: 60,
|
|
filters: {},
|
|
refreshChart() {},
|
|
toggleExpandSlice() {},
|
|
addFilter() {},
|
|
editMode: false,
|
|
isExpanded: false,
|
|
supersetCanExplore: false,
|
|
sliceCanEdit: false,
|
|
};
|
|
|
|
function setup(overrideProps) {
|
|
const wrapper = shallow(<Chart {...props} {...overrideProps} />);
|
|
return wrapper;
|
|
}
|
|
|
|
it('should render a SliceHeader', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(SliceHeader)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render a ChartContainer', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find(ChartContainer)).toHaveLength(1);
|
|
});
|
|
|
|
it('should render a description if it has one and isExpanded=true', () => {
|
|
const wrapper = setup();
|
|
expect(wrapper.find('.slice_description')).toHaveLength(0);
|
|
|
|
wrapper.setProps({ ...props, isExpanded: true });
|
|
expect(wrapper.find('.slice_description')).toHaveLength(1);
|
|
});
|
|
|
|
it('should call refreshChart when SliceHeader calls forceRefresh', () => {
|
|
const refreshChart = sinon.spy();
|
|
const wrapper = setup({ refreshChart });
|
|
wrapper.instance().forceRefresh();
|
|
expect(refreshChart.callCount).toBe(1);
|
|
});
|
|
|
|
it('should call addFilter when ChartContainer calls addFilter', () => {
|
|
const addFilter = sinon.spy();
|
|
const wrapper = setup({ addFilter });
|
|
wrapper.instance().addFilter();
|
|
expect(addFilter.callCount).toBe(1);
|
|
});
|
|
|
|
it('should return props.filters when its getFilters method is called', () => {
|
|
const filters = { column: ['value'] };
|
|
const wrapper = setup({ filters });
|
|
expect(wrapper.instance().getFilters()).toBe(filters);
|
|
});
|
|
});
|