mirror of
https://github.com/apache/superset.git
synced 2026-04-09 11:25:23 +00:00
9029701f24
* [refactor] Migrate from Mocha+Chai to Jest This change migrates all the existing unit tests - to Jest's global expect and matchers from chai's imported expect, asserts and matchers. - to Jest's describe/test from mocha's describe/it The majority of the mechanical changes to tests are achieved through running jest-codemods. The only two note-worthy manual tweaks: 1. Setting a testURL of http://localhost in jest config and adjusting a few tests to leverage this value instead of relying on about:blank. 2. Re-enabling ExploreChartPanel_spec which was previously commented out as we cannot have empty tests with nothing in it with Jest. :) This change also removes dependencies to Mocha and Chai. * Remove the test:one command as it now does the same thing as test. * Fixing lint errors. The diff looks large but is large done through `yarn run lint --fix` The only noteworthy change is the one in eslintrc for tests. The env has been updated from mocha to jest. * Adding eslint-plugin-jest and further modify tests. - One small fix in sqllab's Timer Spec for a test that is not using the spy it created for testing. - Deletion of a duplicated test caught by eslint-plugin-jest. * - Make istanbul coverage work with Jest. - Remove dependency on stand-alone istanbul and babel-istanbul as they're built-into jest. Yes! * Attempt to fix dynamic imports in tests. * run sequentially and log heap usage * - tweaking maxworkers for travis and specifying coverageDirectory for codecov - remove dynamic import in shim.js now that it is set in babelrc for tests only.
64 lines
1.5 KiB
JavaScript
64 lines
1.5 KiB
JavaScript
import Preset from '../../../../src/visualizations/core/models/Preset';
|
|
import Plugin from '../../../../src/visualizations/core/models/Plugin';
|
|
|
|
describe('Preset', () => {
|
|
it('exists', () => {
|
|
expect(Preset).toBeDefined();
|
|
});
|
|
|
|
describe('new Preset()', () => {
|
|
it('creates new preset', () => {
|
|
const preset = new Preset();
|
|
expect(preset).toBeInstanceOf(Preset);
|
|
});
|
|
});
|
|
|
|
describe('.register()', () => {
|
|
it('register all listed presets then plugins', () => {
|
|
const values = [];
|
|
class Plugin1 extends Plugin {
|
|
register() {
|
|
values.push(1);
|
|
}
|
|
}
|
|
class Plugin2 extends Plugin {
|
|
register() {
|
|
values.push(2);
|
|
}
|
|
}
|
|
class Plugin3 extends Plugin {
|
|
register() {
|
|
values.push(3);
|
|
}
|
|
}
|
|
class Plugin4 extends Plugin {
|
|
register() {
|
|
const { key } = this.config;
|
|
values.push(key);
|
|
}
|
|
}
|
|
|
|
const preset1 = new Preset({
|
|
plugins: [new Plugin1()],
|
|
});
|
|
const preset2 = new Preset({
|
|
plugins: [new Plugin2()],
|
|
});
|
|
const preset3 = new Preset({
|
|
presets: [preset1, preset2],
|
|
plugins: [
|
|
new Plugin3(),
|
|
new Plugin4().configure({ key: 'abc' }),
|
|
],
|
|
});
|
|
preset3.register();
|
|
expect(values).toEqual([1, 2, 3, 'abc']);
|
|
});
|
|
|
|
it('returns itself', () => {
|
|
const preset = new Preset();
|
|
expect(preset.register()).toBe(preset);
|
|
});
|
|
});
|
|
});
|