Files
superset2/superset-frontend/spec/helpers/jsDomWithFetchAPI.ts
Evan Rusackas e35c7ae536 feat(frontend): upgrade Ant Design from v5 to v6
Upgrades antd 5.26 -> 6.5 (and @ant-design/icons -> 6) across the frontend.

Theme-safe: the getDesignToken -> allowedAntdTokens -> ConfigProvider/Emotion
bridge works on v6 with no token loss (only cosmetic box-shadow recomputation).
Adds theme characterization tests that lock the full computed token set for
light and dark so any future token rename/removal fails loudly.

Key changes:
- Theme bridge: coerce boolean `cssVar` (removed from v6 ThemeConfig) to the
  object form.
- Wrappers/app: Select (dropdownAlign removed; showSearch/tokenSeparators union
  handling), Tooltip/Popover/DropdownContainer styles.body -> styles.container,
  Steps.Step -> items, Popover/Tooltip/Dropdown visible/onVisibleChange ->
  open/onOpenChange, Dropdown overlay -> menu, Pagination size="default"
  removed, .ant-tooltip-inner -> .ant-tooltip-container and
  .ant-select-selector -> .ant-select-content in styled CSS.
- Fixes a real regression the tests caught: antd v6 Tag overwrites its `icon`
  prop's inline style, dropping Label icon colors; fixed by wrapping the icon.
- Deps: remove unused @rjsf/antd (pinned antd 5); bump @rjsf/core/utils/
  validator-ajv8 to v6; pin jsonforms-antd-renderers to antd 6 via overrides.
- Test env: replace the `MessageChannel = undefined` stub with a polyfill
  (antd v6's scheduler needs the constructor).
- Update test-DOM assertions across suites for v6 class/structure renames.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 01:47:11 -07:00

122 lines
4.6 KiB
TypeScript

/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import JSDOMEnvironment from 'jest-environment-jsdom';
// jest-environment-jsdom 30 bundles jsdom 26, which marks window.location as
// [LegacyUnforgeable] (configurable: false). jest 30's spyOn now strictly
// checks the configurable flag and throws when it's false, breaking every test
// that uses jest.spyOn(window, 'location', 'get').
//
// We intercept Object.defineProperties at module-load time (before any JSDOM
// instance is created). The interceptor makes window.location configurable
// every time jsdom creates a new Window, restoring the ability to spy on it.
// This file is only required by Jest in the test environment so the
// monkey-patch is safe.
const _originalDefineProperties = Object.defineProperties.bind(Object);
(Object as any).defineProperties = function (
obj: object,
props: PropertyDescriptorMap,
) {
if (
props !== null &&
typeof props === 'object' &&
Object.prototype.hasOwnProperty.call(props, 'location') &&
(props as any).location?.configurable === false
) {
// Allow jest.spyOn(window, 'location', 'get') to work in tests by making
// the property configurable. This deviates from the browser spec's
// [LegacyUnforgeable] requirement but is acceptable in a test environment.
props = {
...props,
location: { ...(props as any).location, configurable: true },
};
}
return _originalDefineProperties(obj, props);
};
// https://github.com/facebook/jest/blob/v29.4.3/website/versioned_docs/version-29.4/Configuration.md#testenvironment-string
export default class FixJSDOMEnvironment extends JSDOMEnvironment {
constructor(...args: ConstructorParameters<typeof JSDOMEnvironment>) {
super(...args);
// FIXME https://github.com/jsdom/jsdom/issues/1724
this.global.fetch = fetch;
this.global.Headers = Headers;
this.global.Request = Request;
this.global.Response = Response;
this.global.AbortSignal = AbortSignal;
this.global.AbortController = AbortController;
this.global.ReadableStream = ReadableStream;
// Ant Design v6's scheduler instantiates `new MessageChannel()` directly, so
// the previous `undefined` stub (a workaround for an rc-overflow@1.4.1
// MessagePort leak, see https://github.com/apache/superset/pull/34871) now
// throws "MessageChannel is not a constructor". jsdom's native MessageChannel
// delivers asynchronously and does not flush inside testing-library's act(),
// so we provide a lightweight polyfill that delivers messages as macrotasks
// (matching React's own setTimeout scheduler fallback). setTimeout(0) does
// not keep the event loop alive, so the original hang does not return.
class PolyfillMessagePort {
onmessage: ((event: { data: unknown }) => void) | null = null;
private listeners: Array<(event: { data: unknown }) => void> = [];
_peer: PolyfillMessagePort | null = null;
postMessage(data: unknown) {
const peer = this._peer;
if (!peer) return;
setTimeout(() => {
peer.onmessage?.({ data });
peer.listeners.forEach(fn => fn({ data }));
}, 0);
}
addEventListener(type: string, fn: (event: { data: unknown }) => void) {
if (type === 'message') this.listeners.push(fn);
}
removeEventListener(
type: string,
fn: (event: { data: unknown }) => void,
) {
if (type === 'message')
this.listeners = this.listeners.filter(l => l !== fn);
}
start() {}
close() {}
}
class PolyfillMessageChannel {
port1 = new PolyfillMessagePort();
port2 = new PolyfillMessagePort();
constructor() {
this.port1._peer = this.port2;
this.port2._peer = this.port1;
}
}
this.global.MessageChannel = PolyfillMessageChannel as any;
this.global.MessagePort = PolyfillMessagePort as any;
}
}