Files
superset2/superset-frontend/src/explore/components/controls/NumberControl/NumberControl.test.tsx
Evan Rusackas e35c7ae536 feat(frontend): upgrade Ant Design from v5 to v6
Upgrades antd 5.26 -> 6.5 (and @ant-design/icons -> 6) across the frontend.

Theme-safe: the getDesignToken -> allowedAntdTokens -> ConfigProvider/Emotion
bridge works on v6 with no token loss (only cosmetic box-shadow recomputation).
Adds theme characterization tests that lock the full computed token set for
light and dark so any future token rename/removal fails loudly.

Key changes:
- Theme bridge: coerce boolean `cssVar` (removed from v6 ThemeConfig) to the
  object form.
- Wrappers/app: Select (dropdownAlign removed; showSearch/tokenSeparators union
  handling), Tooltip/Popover/DropdownContainer styles.body -> styles.container,
  Steps.Step -> items, Popover/Tooltip/Dropdown visible/onVisibleChange ->
  open/onOpenChange, Dropdown overlay -> menu, Pagination size="default"
  removed, .ant-tooltip-inner -> .ant-tooltip-container and
  .ant-select-selector -> .ant-select-content in styled CSS.
- Fixes a real regression the tests caught: antd v6 Tag overwrites its `icon`
  prop's inline style, dropping Label icon colors; fixed by wrapping the icon.
- Deps: remove unused @rjsf/antd (pinned antd 5); bump @rjsf/core/utils/
  validator-ajv8 to v6; pin jsonforms-antd-renderers to antd 6 via overrides.
- Test env: replace the `MessageChannel = undefined` stub with a polyfill
  (antd v6's scheduler needs the constructor).
- Update test-DOM assertions across suites for v6 class/structure renames.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
2026-07-01 01:47:11 -07:00

113 lines
3.2 KiB
TypeScript

/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { render, screen, userEvent } from 'spec/helpers/testing-library';
import NumberControl from '.';
const mockedProps = {
min: -5,
max: 10,
step: 1,
default: 0,
};
test('render', () => {
const { container } = render(<NumberControl {...mockedProps} />);
expect(container).toBeInTheDocument();
});
test('type number and blur triggers onChange', async () => {
const props = {
...mockedProps,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const input = screen.getByRole('spinbutton');
userEvent.type(input, '9');
userEvent.tab(); // Trigger blur to dispatch
expect(props.onChange).toHaveBeenLastCalledWith(9);
});
test('type value exceeding max and blur', async () => {
const props = {
...mockedProps,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const input = screen.getByRole('spinbutton');
userEvent.type(input, '20');
userEvent.tab(); // Trigger blur to dispatch
expect(props.onChange).toHaveBeenCalled();
});
test('type NaN keeps original value', async () => {
const props = {
...mockedProps,
value: 5,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const input = screen.getByRole('spinbutton');
userEvent.type(input, 'not a number');
userEvent.tab(); // Trigger blur
expect(props.onChange).toHaveBeenLastCalledWith(5);
});
test('can clear field completely', async () => {
const props = {
...mockedProps,
value: 10,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const input = screen.getByRole('spinbutton');
userEvent.clear(input);
userEvent.tab(); // Trigger blur
expect(props.onChange).toHaveBeenLastCalledWith(undefined);
});
test('stepper arrows trigger onChange immediately', async () => {
const props = {
...mockedProps,
value: 5,
onChange: jest.fn(),
};
render(<NumberControl {...props} />);
const upButton = document.querySelector(
'.ant-input-number-action-up',
) as HTMLElement;
expect(upButton).toBeInTheDocument();
await userEvent.click(upButton);
expect(props.onChange).toHaveBeenCalledWith(6);
});
test('updates local value when prop changes', () => {
const props = {
...mockedProps,
value: 5,
onChange: jest.fn(),
};
const { rerender } = render(<NumberControl {...props} />);
const input = screen.getByRole('spinbutton');
expect(input).toHaveValue('5');
rerender(<NumberControl {...props} value={8} />);
expect(input).toHaveValue('8');
});