The original implementation had critical threading issues:
- Global session reassignment (db.session = db.create_scoped_session())
was catastrophic in multi-threaded environments
- Unnecessary connection state management fought Flask-SQLAlchemy
- Complex logic that was difficult to verify
This improved implementation:
- Only affects current thread (thread-safe via scoped_session)
- Works with NullPool to actually close connections
- Never mutates global state
- Lets Flask-SQLAlchemy handle session recreation automatically
- Comprehensive unit tests to verify behavior
The fix maintains the same public API and feature flag behavior
while eliminating race conditions and session corruption issues.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
f57b5e03bb