mirror of
https://github.com/apache/superset.git
synced 2026-04-19 08:04:53 +00:00
959b15eeca
* feat: Adds a key-value endpoint to store charts form data * Fixes linting problems * Removes the query_params from the endpoints * Refactors the commands * Removes unused imports * Changes the parameters to use dataclass * Adds more access tests * Gets the first dataset while testing * Adds unit tests for the check_access function * Changes the can_access check * Always check for dataset access
38 lines
1.8 KiB
Python
38 lines
1.8 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
from superset.charts.form_data.utils import check_access, get_dataset_id
|
|
from superset.extensions import cache_manager
|
|
from superset.key_value.commands.delete import DeleteKeyValueCommand
|
|
from superset.key_value.commands.entry import Entry
|
|
from superset.key_value.commands.exceptions import KeyValueAccessDeniedError
|
|
from superset.key_value.commands.parameters import CommandParameters
|
|
from superset.key_value.utils import cache_key
|
|
|
|
|
|
class DeleteFormDataCommand(DeleteKeyValueCommand):
|
|
def delete(self, cmd_params: CommandParameters) -> bool:
|
|
check_access(cmd_params)
|
|
resource_id = cmd_params.resource_id
|
|
actor = cmd_params.actor
|
|
key = cache_key(resource_id or get_dataset_id(cmd_params), cmd_params.key)
|
|
entry: Entry = cache_manager.chart_form_data_cache.get(key)
|
|
if entry:
|
|
if entry["owner"] != actor.get_user_id():
|
|
raise KeyValueAccessDeniedError()
|
|
return cache_manager.chart_form_data_cache.delete(key)
|
|
return True
|