mirror of
https://github.com/apache/superset.git
synced 2026-09-05 23:12:01 +00:00
Claude Code
fb5029d06d
The capture tool discovered ~53 viz types across the example dashboards but only ever captured one representative chart per type into thumbnail.png; every gallery slot beyond that was hand-made art that predated any of this, unrelated to what the example dashboards actually contain. Two of those hand-made images turned out to be faked outright: ag-grid-table's and cartodiagram's "dark" variants were a naive full-image color inversion of the light one rather than a real dark-theme render (confirmed by pixel-diffing every light/dark pair in the repo -- these two matched a naive invert at 85-99%, every genuine capture matched at under 2%). To fix this without silently losing the old art or shipping anything dishonest: 1. Every existing thumbnail/gallery image was renamed with a custom_thumb_ prefix (plugin imports updated to match), so it's preserved and clearly labeled as hand-made rather than captured. 2. The capture script (capture-viz-thumbnails.spec.ts) was generalized: it now captures every distinct chart per viz type, not just one -- the preferred (or alphabetically-first) chart becomes the picker thumbnail, and every other distinct chart fills the next already-declared exampleGallery slot, via a new VIZ_TYPE_GALLERY map mirroring VIZ_TYPE_THUMBNAILS. Also fixed a pre-existing bug where VIZ_TYPE_THUMBNAILS.rose pointed at plugin-chart-rose, a package consolidated into plugin-chart-echarts/src/Rose long ago. 3. Ran it for real against a live instance with examples loaded (including the new Deck.gl GeoJson example). Every plugin whose real capture succeeded had its import flipped from the custom_thumb_ file back to the plain, freshly-captured one. 4. For deck.gl chart types, the dark "capture" is confirmed genuinely pixel-identical to light (they render static map tiles that don't respond to prefers-color-scheme) rather than skipped/left stale, so the plain dark file is an honest copy of the real light capture instead of mismatched old art. Four viz types still have zero chart on any example dashboard and keep their custom_thumb_ imports as an honest label rather than a graduated (but fake) real capture: - cartodiagram: needs a hand-crafted embedded sub-chart config - deck_multi: sub-layers are referenced by raw DB-assigned chart ids with no UUID-based remap path through the YAML importer -- a real gap needing an importer/exporter fix, not something a fixture alone can solve - pop_kpi, ag-grid-table: gated behind ChartPluginsExperimental / AgGridTableEnabled and unregistered by default, so a default-visible dashboard chart would just show every regular user a broken card