mirror of
https://github.com/apache/superset.git
synced 2026-07-04 05:45:32 +00:00
104 lines
3.6 KiB
YAML
104 lines
3.6 KiB
YAML
name: pre-commit checks
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- "master"
|
|
- "[0-9].[0-9]*"
|
|
pull_request:
|
|
types: [synchronize, opened, reopened, ready_for_review]
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
# cancel previous workflow jobs for PRs
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
pre-commit:
|
|
runs-on: ubuntu-24.04
|
|
timeout-minutes: 20
|
|
strategy:
|
|
matrix:
|
|
# Run the full version spread on push (master/release) and nightly,
|
|
# but only the current version on PRs — lint/format/type results
|
|
# rarely differ across patch versions, so 3x per PR is wasteful.
|
|
python-version: ${{ github.event_name == 'pull_request' && fromJSON('["current"]') || fromJSON('["current", "previous", "next"]') }}
|
|
steps:
|
|
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
|
|
with:
|
|
persist-credentials: false
|
|
submodules: recursive
|
|
|
|
- name: Setup Python
|
|
uses: ./.github/actions/setup-backend/
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
|
|
- name: Setup Go
|
|
uses: actions/setup-go@924ae3a1cded613372ab5595356fb5720e22ba16 # v6.5.0
|
|
|
|
- name: Install helm-docs
|
|
run: go install github.com/norwoodj/helm-docs/cmd/helm-docs@v1.14.2
|
|
|
|
- name: Setup Node.js
|
|
uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # v6
|
|
with:
|
|
node-version-file: "superset-frontend/.nvmrc"
|
|
cache: "npm"
|
|
cache-dependency-path: "superset-frontend/package-lock.json"
|
|
|
|
- name: Install Frontend Dependencies
|
|
run: |
|
|
cd superset-frontend
|
|
npm ci
|
|
|
|
- name: Install Docs Dependencies
|
|
run: |
|
|
cd docs
|
|
yarn install --immutable
|
|
|
|
- name: Cache pre-commit environments
|
|
uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
|
|
with:
|
|
path: ~/.cache/pre-commit
|
|
key: pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}-${{ hashFiles('.pre-commit-config.yaml') }}
|
|
restore-keys: |
|
|
pre-commit-v2-${{ runner.os }}-py${{ matrix.python-version }}-
|
|
|
|
- name: Get changed files
|
|
id: changed_files
|
|
uses: ./.github/actions/file-changes-action
|
|
with:
|
|
output: " "
|
|
|
|
- name: pre-commit
|
|
env:
|
|
CHANGED_FILES: ${{ steps.changed_files.outputs.files }}
|
|
run: |
|
|
set +e # Don't exit immediately on failure
|
|
export SKIP=type-checking-frontend
|
|
pre-commit run --files $CHANGED_FILES
|
|
PRE_COMMIT_EXIT_CODE=$?
|
|
git diff --quiet --exit-code
|
|
GIT_DIFF_EXIT_CODE=$?
|
|
if [ "${PRE_COMMIT_EXIT_CODE}" -ne 0 ] || [ "${GIT_DIFF_EXIT_CODE}" -ne 0 ]; then
|
|
if [ "${PRE_COMMIT_EXIT_CODE}" -ne 0 ]; then
|
|
echo "❌ Pre-commit check failed (exit code: ${PRE_COMMIT_EXIT_CODE})."
|
|
echo "🔍 Modified files:"
|
|
git diff --name-only
|
|
else
|
|
echo "❌ Git working directory is dirty."
|
|
echo "📌 This likely means that pre-commit made changes that were not committed."
|
|
echo "🔍 Modified files:"
|
|
git diff --name-only
|
|
fi
|
|
|
|
echo "🚒 To prevent/address this CI issue, please install/use pre-commit locally."
|
|
echo "📖 More details here: https://superset.apache.org/docs/contributing/development#git-hooks"
|
|
exit 1
|
|
fi
|