mirror of
https://github.com/apache/superset.git
synced 2026-04-17 15:15:20 +00:00
003e98c231
* Build support for schema access in Superset and SQLab * Lint * Test for old and new flask * Black formatting * Cleanup modified files * Support schema permissions * Add migration * Make it work for slices as well * TODO and remove unused field * Apply schema access check to dashboards as well Cleaner schema permissions check Fetch schema permissions in 1 query Bugfix Better datasource check Use security manager for permissions checks and remove dead code Properly handle anon user Add database permissions on the database updates Fix schema filtering Lint / flake changes Increase cypress request timeout Run black Resolve multiple alembic heads * Use set comprehensions * Fixes for the pylint
100 lines
3.0 KiB
Python
100 lines
3.0 KiB
Python
# Licensed to the Apache Software Foundation (ASF) under one
|
|
# or more contributor license agreements. See the NOTICE file
|
|
# distributed with this work for additional information
|
|
# regarding copyright ownership. The ASF licenses this file
|
|
# to you under the Apache License, Version 2.0 (the
|
|
# "License"); you may not use this file except in compliance
|
|
# with the License. You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing,
|
|
# software distributed under the License is distributed on an
|
|
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
# KIND, either express or implied. See the License for the
|
|
# specific language governing permissions and limitations
|
|
# under the License.
|
|
"""serialize_schema_permissions.py
|
|
|
|
Revision ID: 5afa9079866a
|
|
Revises: db4b49eb0782
|
|
Create Date: 2019-09-11 21:49:00.608346
|
|
|
|
"""
|
|
|
|
|
|
# revision identifiers, used by Alembic.
|
|
from alembic import op
|
|
from sqlalchemy import Column, ForeignKey, Integer, String
|
|
from sqlalchemy.ext.declarative import declarative_base
|
|
from sqlalchemy.orm import relationship
|
|
|
|
from superset import db
|
|
|
|
revision = "5afa9079866a"
|
|
down_revision = "db4b49eb0782"
|
|
|
|
Base = declarative_base()
|
|
|
|
|
|
class Sqlatable(Base):
|
|
__tablename__ = "tables"
|
|
|
|
id = Column(Integer, primary_key=True)
|
|
perm = Column(String(1000))
|
|
schema_perm = Column(String(1000))
|
|
schema = Column(String(255))
|
|
database_id = Column(Integer, ForeignKey("dbs.id"), nullable=False)
|
|
database = relationship("Database", foreign_keys=[database_id])
|
|
|
|
|
|
class Slice(Base):
|
|
__tablename__ = "slices"
|
|
|
|
id = Column(Integer, primary_key=True)
|
|
datasource_id = Column(Integer)
|
|
datasource_type = Column(String(200))
|
|
schema_perm = Column(String(1000))
|
|
|
|
|
|
class Database(Base):
|
|
__tablename__ = "dbs"
|
|
|
|
id = Column(Integer, primary_key=True)
|
|
database_name = Column(String(250))
|
|
verbose_name = Column(String(250), unique=True)
|
|
|
|
|
|
def upgrade():
|
|
op.add_column(
|
|
"datasources", Column("schema_perm", String(length=1000), nullable=True)
|
|
)
|
|
op.add_column("slices", Column("schema_perm", String(length=1000), nullable=True))
|
|
op.add_column("tables", Column("schema_perm", String(length=1000), nullable=True))
|
|
|
|
bind = op.get_bind()
|
|
session = db.Session(bind=bind)
|
|
for t in session.query(Sqlatable).all():
|
|
db_name = (
|
|
t.database.verbose_name
|
|
if t.database.verbose_name
|
|
else t.database.database_name
|
|
)
|
|
if t.schema:
|
|
t.schema_perm = f"[{db_name}].[{t.schema}]"
|
|
table_slices = (
|
|
session.query(Slice)
|
|
.filter_by(datasource_type="table")
|
|
.filter_by(datasource_id=t.id)
|
|
.all()
|
|
)
|
|
for s in table_slices:
|
|
s.schema_perm = t.schema_perm
|
|
session.commit()
|
|
|
|
|
|
def downgrade():
|
|
op.drop_column("tables", "schema_perm")
|
|
op.drop_column("datasources", "schema_perm")
|
|
op.drop_column("slices", "schema_perm")
|