mirror of
https://github.com/apache/superset.git
synced 2026-04-18 07:35:09 +00:00
* [sql lab] simplify the visualize flow The "visualize flow" linking SQL Lab to the "explore view" has never worked so great for people, here's a list of issues: * it's not really clear to users that their query is wrapped as a subquery, and the explore view runs queries on top of it * lint + fix tests * Addressing comments
226 lines
6.6 KiB
JavaScript
226 lines
6.6 KiB
JavaScript
import React from 'react';
|
|
import configureStore from 'redux-mock-store';
|
|
import thunk from 'redux-thunk';
|
|
|
|
import { shallow } from 'enzyme';
|
|
import { describe, it } from 'mocha';
|
|
import { expect } from 'chai';
|
|
import sinon from 'sinon';
|
|
|
|
import $ from 'jquery';
|
|
import shortid from 'shortid';
|
|
import { queries } from './fixtures';
|
|
import { sqlLabReducer } from '../../../src/SqlLab/reducers';
|
|
import * as actions from '../../../src/SqlLab/actions';
|
|
import ExploreResultsButton from '../../../src/SqlLab/components/ExploreResultsButton';
|
|
import * as exploreUtils from '../../../src/explore/exploreUtils';
|
|
import Button from '../../../src/components/Button';
|
|
|
|
describe('ExploreResultsButton', () => {
|
|
const middlewares = [thunk];
|
|
const mockStore = configureStore(middlewares);
|
|
const database = {
|
|
allows_subquery: true,
|
|
};
|
|
const initialState = {
|
|
sqlLab: {
|
|
...sqlLabReducer(undefined, {}),
|
|
common: {
|
|
conf: { SUPERSET_WEBSERVER_TIMEOUT: 45 },
|
|
},
|
|
},
|
|
};
|
|
const store = mockStore(initialState);
|
|
const mockedProps = {
|
|
database,
|
|
show: true,
|
|
query: queries[0],
|
|
};
|
|
const mockColumns = {
|
|
ds: {
|
|
is_date: true,
|
|
is_dim: false,
|
|
name: 'ds',
|
|
type: 'STRING',
|
|
},
|
|
gender: {
|
|
is_date: false,
|
|
is_dim: true,
|
|
name: 'gender',
|
|
type: 'STRING',
|
|
},
|
|
};
|
|
const mockChartTypeBarChart = {
|
|
label: 'Distribution - Bar Chart',
|
|
requiresTime: false,
|
|
value: 'dist_bar',
|
|
};
|
|
const mockChartTypeTB = {
|
|
label: 'Time Series - Bar Chart',
|
|
requiresTime: true,
|
|
value: 'bar',
|
|
};
|
|
const getExploreResultsButtonWrapper = () => (
|
|
shallow(<ExploreResultsButton {...mockedProps} />, {
|
|
context: { store },
|
|
}).dive());
|
|
|
|
it('renders', () => {
|
|
expect(React.isValidElement(<ExploreResultsButton />)).to.equal(true);
|
|
});
|
|
it('renders with props', () => {
|
|
expect(
|
|
React.isValidElement(<ExploreResultsButton {...mockedProps} />),
|
|
).to.equal(true);
|
|
});
|
|
it('renders a Button', () => {
|
|
const wrapper = getExploreResultsButtonWrapper();
|
|
expect(wrapper.find(Button)).to.have.length(1);
|
|
});
|
|
|
|
describe('getColumnFromProps', () => {
|
|
it('should require valid query parameter in props', () => {
|
|
const emptyQuery = {
|
|
database,
|
|
show: true,
|
|
query: {},
|
|
};
|
|
const wrapper = shallow(<ExploreResultsButton {...emptyQuery} />, {
|
|
context: { store },
|
|
}).dive();
|
|
expect(wrapper.state().hints).to.deep.equal([]);
|
|
});
|
|
});
|
|
|
|
describe('datasourceName', () => {
|
|
let wrapper;
|
|
let stub;
|
|
beforeEach(() => {
|
|
wrapper = getExploreResultsButtonWrapper();
|
|
stub = sinon.stub(shortid, 'generate').returns('abcd');
|
|
});
|
|
afterEach(() => {
|
|
stub.restore();
|
|
});
|
|
|
|
it('should generate data source name from query', () => {
|
|
const sampleQuery = queries[0];
|
|
const name = wrapper.instance().datasourceName();
|
|
expect(name).to.equal(`${sampleQuery.user}-${sampleQuery.tab}-abcd`);
|
|
});
|
|
it('should generate data source name with empty query', () => {
|
|
wrapper.setProps({ query: {} });
|
|
const name = wrapper.instance().datasourceName();
|
|
expect(name).to.equal('undefined-abcd');
|
|
});
|
|
|
|
it('should build viz options', () => {
|
|
wrapper.setState({ chartType: mockChartTypeTB });
|
|
const spy = sinon.spy(wrapper.instance(), 'buildVizOptions');
|
|
wrapper.instance().buildVizOptions();
|
|
expect(spy.returnValues[0]).to.deep.equal({
|
|
schema: 'test_schema',
|
|
sql: wrapper.instance().props.query.sql,
|
|
dbId: wrapper.instance().props.query.dbId,
|
|
columns: Object.values(mockColumns),
|
|
templateParams: undefined,
|
|
datasourceName: 'admin-Demo-abcd',
|
|
});
|
|
});
|
|
});
|
|
|
|
it('should build visualize advise for long query', () => {
|
|
const longQuery = { ...queries[0], endDttm: 1476910666798 };
|
|
const props = {
|
|
show: true,
|
|
query: longQuery,
|
|
database,
|
|
};
|
|
const longQueryWrapper = shallow(<ExploreResultsButton {...props} />, {
|
|
context: { store },
|
|
}).dive();
|
|
const inst = longQueryWrapper.instance();
|
|
expect(inst.getQueryDuration()).to.equal(100.7050400390625);
|
|
});
|
|
|
|
describe('visualize', () => {
|
|
const wrapper = getExploreResultsButtonWrapper();
|
|
const mockOptions = { attr: 'mockOptions' };
|
|
wrapper.setState({
|
|
chartType: mockChartTypeBarChart,
|
|
datasourceName: 'mockDatasourceName',
|
|
});
|
|
|
|
let ajaxSpy;
|
|
let datasourceSpy;
|
|
beforeEach(() => {
|
|
ajaxSpy = sinon.spy($, 'ajax');
|
|
sinon.stub(JSON, 'parse').callsFake(() => ({ table_id: 107 }));
|
|
sinon.stub(exploreUtils, 'getExploreUrlAndPayload').callsFake(() => ({ url: 'mockURL', payload: { datasource: '107__table' } }));
|
|
sinon.spy(exploreUtils, 'exportChart');
|
|
sinon.stub(wrapper.instance(), 'buildVizOptions').callsFake(() => (mockOptions));
|
|
datasourceSpy = sinon.stub(actions, 'createDatasource');
|
|
});
|
|
afterEach(() => {
|
|
ajaxSpy.restore();
|
|
JSON.parse.restore();
|
|
exploreUtils.getExploreUrlAndPayload.restore();
|
|
exploreUtils.exportChart.restore();
|
|
wrapper.instance().buildVizOptions.restore();
|
|
datasourceSpy.restore();
|
|
});
|
|
|
|
it('should build request', () => {
|
|
wrapper.instance().visualize();
|
|
expect(ajaxSpy.callCount).to.equal(1);
|
|
|
|
const spyCall = ajaxSpy.getCall(0);
|
|
expect(spyCall.args[0].type).to.equal('POST');
|
|
expect(spyCall.args[0].url).to.equal('/superset/sqllab_viz/');
|
|
expect(spyCall.args[0].data.data).to.equal(JSON.stringify(mockOptions));
|
|
});
|
|
it('should open new window', () => {
|
|
const infoToastSpy = sinon.spy();
|
|
|
|
datasourceSpy.callsFake(() => {
|
|
const d = $.Deferred();
|
|
d.resolve('done');
|
|
return d.promise();
|
|
});
|
|
|
|
wrapper.setProps({
|
|
actions: {
|
|
createDatasource: datasourceSpy,
|
|
addInfoToast: infoToastSpy,
|
|
},
|
|
});
|
|
|
|
wrapper.instance().visualize();
|
|
expect(exploreUtils.exportChart.callCount).to.equal(1);
|
|
expect(exploreUtils.exportChart.getCall(0).args[0].datasource).to.equal('107__table');
|
|
expect(infoToastSpy.callCount).to.equal(1);
|
|
});
|
|
it('should add error toast', () => {
|
|
const dangerToastSpy = sinon.spy();
|
|
|
|
datasourceSpy.callsFake(() => {
|
|
const d = $.Deferred();
|
|
d.reject('error message');
|
|
return d.promise();
|
|
});
|
|
|
|
|
|
wrapper.setProps({
|
|
actions: {
|
|
createDatasource: datasourceSpy,
|
|
addDangerToast: dangerToastSpy,
|
|
},
|
|
});
|
|
|
|
wrapper.instance().visualize();
|
|
expect(exploreUtils.exportChart.callCount).to.equal(0);
|
|
expect(dangerToastSpy.callCount).to.equal(1);
|
|
});
|
|
});
|
|
});
|