Add security measures for SSO-only users: block password resets, enforce SSO authentication, and refactor validations for JIT provisioning. (#569)

Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
This commit is contained in:
LPW
2026-01-07 14:17:23 -05:00
committed by GitHub
parent 66671d9e1f
commit 02e203e8ee
9 changed files with 191 additions and 10 deletions

View File

@@ -48,4 +48,43 @@ class PasswordResetsControllerTest < ActionDispatch::IntegrationTest
assert_redirected_to new_session_path
assert_equal "Password reset via Sure is disabled. Please reset your password through your identity provider.", flash[:alert]
end
# Security: SSO-only users should not receive password reset emails
test "create does not send email for SSO-only user" do
sso_user = users(:sso_only)
assert sso_user.sso_only?, "Test user should be SSO-only"
assert_no_enqueued_emails do
post password_reset_path, params: { email: sso_user.email }
end
# Should still redirect to pending to prevent email enumeration
assert_redirected_to new_password_reset_url(step: "pending")
end
test "create sends email for user with local password" do
assert @user.has_local_password?, "Test user should have local password"
assert_enqueued_emails 1 do
post password_reset_path, params: { email: @user.email }
end
assert_redirected_to new_password_reset_url(step: "pending")
end
# Security: SSO-only users cannot set password via reset
test "update blocks password setting for SSO-only user" do
sso_user = users(:sso_only)
token = sso_user.generate_token_for(:password_reset)
patch password_reset_path(token: token),
params: { user: { password: "NewSecure1!", password_confirmation: "NewSecure1!" } }
assert_redirected_to new_session_path
assert_equal "Your account uses SSO for authentication. Please contact your administrator to manage your credentials.", flash[:alert]
# Verify password was not set
sso_user.reload
assert_nil sso_user.password_digest, "SSO-only user should still have nil password_digest"
end
end