feat(splits): add exclusion support for splits and improve rendering (#1661)

* feat(splits): add excluded attribute support for split children and improve rendering of split transactions

* address coderabbitai suggestions to improve code quality

* Fix split excluded coercion, DRY helpers, and clean up view partials

Fix boolean coercion bug where string "false" from form params was
truthy in Ruby, causing all split children to be marked excluded.
Use ActiveModel::Type::Boolean for explicit casting in Entry#split!.

Additional changes addressing code review feedback:

- Extract duplicated in_split_group logic from TransactionsController
  and TransactionCategoriesController into TransactionsHelper
- Remove redundant local_assigns.fetch calls in partials that already
  declare defaults via the Rails 7.1 locals: magic comment
- Simplify ternary in _transaction.html.erb to pass grouped directly
- Guard hidden_field_tag :grouped to only emit when value is "true"
- Add model tests for excluded on split children (boolean and string)
- Add controller test for excluded param through full HTTP stack
- Add test confirming excluded children are dropped from balance queries

* fix(splits): simplify excluded attribute boolean check

* refactor(splits): extract truthy values constant for excluded check

Extract the array of truthy values used for excluded attribute check
into a private constant to improve code maintainability and avoid
duplication of the magic array.

* refactor: simplify split grouping link generation and add test coverage for excluded split parameters
This commit is contained in:
CrossDrain
2026-05-09 10:36:41 +00:00
committed by GitHub
parent 96b1d28d5d
commit 0b7fa732ae
15 changed files with 128 additions and 18 deletions

View File

@@ -174,4 +174,51 @@ class EntrySplitTest < ActiveSupport::TestCase
assert children.first.split_child?
refute @entry.split_child?
end
test "split! creates child entries with excluded: true when specified" do
splits = [
{ name: "Part 1", amount: 50, category_id: nil, excluded: true },
{ name: "Part 2", amount: 50, category_id: nil, excluded: false }
]
children = @entry.split!(splits)
assert_equal 2, children.size
assert children.first.excluded?
refute children.last.excluded?
end
test "split! properly casts excluded from string values" do
splits = [
{ name: "Part 1", amount: 50, category_id: nil, excluded: "true" },
{ name: "Part 2", amount: 50, category_id: nil, excluded: "false" }
]
children = @entry.split!(splits)
assert children.first.excluded?
refute children.last.excluded?
end
test "excluded split children are excluded from balance calculations" do
@entry.split!([
{ name: "Part 1", amount: 50, category_id: nil, excluded: true },
{ name: "Part 2", amount: 50, category_id: nil, excluded: false }
])
# Parent is always excluded for splits
assert @entry.reload.excluded?
# Excluded child should be filtered out by where(excluded: false)
excluded_child = @entry.child_entries.find { |c| c.name == "Part 1" }
non_excluded_child = @entry.child_entries.find { |c| c.name == "Part 2" }
assert excluded_child.excluded?
refute non_excluded_child.excluded?
# where(excluded: false) should only include the non-excluded child
visible_entries = Entry.where(id: @entry.child_entries.map(&:id)).where(excluded: false)
assert_includes visible_entries.pluck(:id), non_excluded_child.id
refute_includes visible_entries.pluck(:id), excluded_child.id
end
end