Improve investment activity labels UX and add convert-to-trade feature (#649)

* Add `investment_activity_label` to trades and enhance activity label handling

- Introduced `investment_activity_label` column to the `trades` table with a migration.
- Backfilled existing `trades` with activity labels based on quantity (`Buy`, `Sell`, or `Other`).
- Replaced `category_id` in trades with `investment_activity_label` for better alignment with transaction labels.
- Updated views and controllers to display and manage activity labels for trades.
- Added localized badge components for displaying and editing labels dynamically.
- Enhanced `PlaidAccount::Investments::TransactionsProcessor` to assign and process activity labels automatically.
- Added investment flows section to reports for tracking contributions and withdrawals.
- Refactored related tests and models for consistency and to ensure proper validation and filtering.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Improve handling of `investment_activity_label`, trade type, and security selection in trades and transactions

- Refined label assignment logic in `trades_controller` to default to `Buy`/`Sell` based on transaction nature.
- Simplified security selection in `transactions_controller` by resolving via unique IDs or custom tickers.
- Streamlined UI for trade and transaction forms by updating dropdown options and label text.
- Enabled quick-edit badges to open `convert_to_trade` modal when applicable, enhancing flexibility.
- Adjusted tests and views to align with updated workflows and ensure consistent behavior.

* Add safeguard for `dropdownTarget` existence in quick edit controller

- Prevent errors by ensuring `dropdownTarget` is present before toggling its visibility.

* Fix undefined method 'category' for Trade on mobile view

Trade model uses investment_activity_label, not category. The upstream
merge introduced a call to trade.category which doesn't exist. Use the
activity label badge on mobile instead.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Fix activity label logic for zero/blank quantity and sell inference

- Return `nil` for blank or zero quantity in `investment_activity_label_for`.
- Correct `is_sell` logic to use the amount’s sign properly in `transactions_controller`.

* Fix i18n key paths in transactions controller for convert_to_trade

- Update flash message translations to use full i18n paths.
- Use `BigDecimal` for quantity and price calculations to improve precision.

---------

Co-authored-by: Josh Waldrep <joshua.waldrep5+github@gmail.com>
Co-authored-by: luckyPipewrench <luckypipewrench@proton.me>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

test/models/account/market_data_importer_test.rb

@@ -79,7 +79,7 @@ class Account::MarketDataImporterTest < ActiveSupport::TestCase
     security = Security.create!(ticker: "AAPL", exchange_operating_mic: "XNAS")
 
     trade_date = 10.days.ago.to_date
-    trade      = Trade.new(security: security, qty: 1, price: 100, currency: "USD")
+    trade      = Trade.new(security: security, qty: 1, price: 100, currency: "USD", investment_activity_label: "Buy")
 
     account.entries.create!(
       name: "Buy AAPL",
@@ -129,7 +129,7 @@ class Account::MarketDataImporterTest < ActiveSupport::TestCase
     security = Security.create!(ticker: "INVALID", exchange_operating_mic: "XNAS")
 
     trade_date = 10.days.ago.to_date
-    trade      = Trade.new(security: security, qty: 1, price: 100, currency: "USD")
+    trade      = Trade.new(security: security, qty: 1, price: 100, currency: "USD", investment_activity_label: "Buy")
 
     account.entries.create!(
       name: "Buy INVALID",

test/models/trade_import_test.rb

@@ -63,20 +63,13 @@ class TradeImportTest < ActiveSupport::TestCase
     assert_equal "complete", @import.status
   end
 
-  test "auto-categorizes buy trades and leaves sell trades uncategorized" do
+  test "auto-assigns investment activity labels to buy and sell trades" do
     aapl = securities(:aapl)
     aapl_resolver = mock
     aapl_resolver.stubs(:resolve).returns(aapl)
     Security::Resolver.stubs(:new).returns(aapl_resolver)
 
-    # Create the investment category if it doesn't exist
     account = accounts(:depository)
-    family = account.family
-    savings_category = family.categories.find_or_create_by!(name: "Savings & Investments") do |c|
-      c.color = "#059669"
-      c.classification = "expense"
-      c.lucide_icon = "piggy-bank"
-    end
 
     import = <<~CSV
       date,ticker,qty,price,currency,name
@@ -109,7 +102,7 @@ class TradeImportTest < ActiveSupport::TestCase
 
     assert_not_nil buy_trade, "Buy trade should have been created"
     assert_not_nil sell_trade, "Sell trade should have been created"
-    assert_equal savings_category, buy_trade.category, "Buy trade should be auto-categorized as Savings & Investments"
-    assert_nil sell_trade.category, "Sell trade should not be auto-categorized"
+    assert_equal "Buy", buy_trade.investment_activity_label, "Buy trade should have 'Buy' activity label"
+    assert_equal "Sell", sell_trade.investment_activity_label, "Sell trade should have 'Sell' activity label"
   end
 end

test/models/trade_test.rb

@@ -30,7 +30,8 @@ class TradeTest < ActiveSupport::TestCase
       security: security,
       price: precise_price,
       qty: 10000,
-      currency: "USD"
+      currency: "USD",
+      investment_activity_label: "Buy"
     )
 
     trade.reload
@@ -47,7 +48,8 @@ class TradeTest < ActiveSupport::TestCase
       security: security,
       price: price_with_too_many_decimals,
       qty: 1,
-      currency: "USD"
+      currency: "USD",
+      investment_activity_label: "Buy"
     )
 
     trade.reload