From 1297078f7e1fd3c03d22126ea3a601cb302117fa Mon Sep 17 00:00:00 2001 From: Roger Saner Date: Mon, 20 Apr 2026 08:17:38 +0200 Subject: [PATCH] Feature: improve transfer matcher UI copy (#1526) * refactor: improve UI copy for transaction matcher drawer * refactor: transfer matcher UI copy * fix: improvement * feat: use i18n --- app/views/transactions/show.html.erb | 2 +- app/views/transfer_matches/new.html.erb | 2 +- config/locales/views/transactions/en.yml | 1 + config/locales/views/transfer_matches/en.yml | 7 +++++++ 4 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 config/locales/views/transfer_matches/en.yml diff --git a/app/views/transactions/show.html.erb b/app/views/transactions/show.html.erb index 5c1176d03..885b7f866 100644 --- a/app/views/transactions/show.html.erb +++ b/app/views/transactions/show.html.erb @@ -349,7 +349,7 @@

Transfer or Debt Payment?

-

Transfers and payments are special types of transactions that indicate money movement between 2 accounts.

+

<%= t(".transfer_matcher_description") %>

<%= render DS::Link.new( text: "Open matcher", diff --git a/app/views/transfer_matches/new.html.erb b/app/views/transfer_matches/new.html.erb index 8a84b9821..2a7c99f8a 100644 --- a/app/views/transfer_matches/new.html.erb +++ b/app/views/transfer_matches/new.html.erb @@ -1,5 +1,5 @@ <%= render DS::Dialog.new do |dialog| %> - <% dialog.with_header(title: "Match transfer or payment") %> + <% dialog.with_header(title: t(".header.title"), subtitle: t(".header.subtitle")) %> <% dialog.with_body do %> <%= styled_form_with( url: transaction_transfer_match_path(@entry), diff --git a/config/locales/views/transactions/en.yml b/config/locales/views/transactions/en.yml index c5b5c3f0c..cc5775645 100644 --- a/config/locales/views/transactions/en.yml +++ b/config/locales/views/transactions/en.yml @@ -45,6 +45,7 @@ en: convert_to_trade_title: Convert to Security Trade convert_to_trade_description: Convert this transaction into a Buy or Sell trade with security details for portfolio tracking. convert_to_trade_button: Convert to Trade + transfer_matcher_description: Connect this transaction to its counterpart in another account. pending_duplicate_merger_title: Duplicate of Posted Transaction? pending_duplicate_merger_description: Manually merge this pending transaction with its posted version. pending_duplicate_merger_button: Open merger diff --git a/config/locales/views/transfer_matches/en.yml b/config/locales/views/transfer_matches/en.yml new file mode 100644 index 000000000..c71247e47 --- /dev/null +++ b/config/locales/views/transfer_matches/en.yml @@ -0,0 +1,7 @@ +--- +en: + transfer_matches: + new: + header: + title: Match transfer or payment + subtitle: Match the corresponding transaction in another account or create one if it doesn't exist.