QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 03:54:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Eliminate code duplication in OIDC identity creation (#230)

Browse Source 
* Eliminate duplication by using create_from_omniauth method

- Updated OidcIdentity.create_from_omniauth to set last_authenticated_at
- Refactored OidcAccountsController to use create_from_omniauth instead of direct create! calls
- Updated test to verify last_authenticated_at is set by create_from_omniauth

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Extract auth hash building into private helper method

- Added build_auth_hash helper method to eliminate OpenStruct creation duplication
- Both create_link and create_user actions now use the same helper

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Linter fix

* Fix button style on OIDC link step

* Fix dark mode styles

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
This commit is contained in:
Copilot
2025-10-25 22:23:28 +02:00
committed by GitHub
parent b24b10262e
commit 1ee20ab3a6
4 changed files with 37 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
test/models/oidc_identity_test.rb
View File

@@ -77,5 +77,6 @@ class OidcIdentityTest < ActiveSupport::TestCase
assert_equal "test@example.com", identity.info["email"]
assert_equal "Test User", identity.info["name"]
assert_equal @user, identity.user
assert_not_nil identity.last_authenticated_at
end
end