From 257286431b2d278d3ac12a2d0ab8ac8d1ea7a144 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Jos=C3=A9=20Mata?= Date: Sat, 11 Apr 2026 00:51:29 +0200 Subject: [PATCH] Fix trade drawer header width regression (#1415) * Fix trade drawer header width regression Wrap the trade header partial in a grow/min-w-0 container inside the custom dialog header row so overview disclosure rows stretch to available width instead of shrinking to content. Confirmed via git blame that this layout behavior predates PR #1248 and is tied to the custom header flex layout introduced in commit 7ae9077. * Overlay trade drawer close button to preserve content width Render the close button absolutely in the custom header instead of as a flex sibling of the full trades header partial. This prevents the button column from shrinking the overview section width and leaving a persistent right-side gutter. --- app/views/trades/show.html.erb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/app/views/trades/show.html.erb b/app/views/trades/show.html.erb index e581d60e3..05519c726 100644 --- a/app/views/trades/show.html.erb +++ b/app/views/trades/show.html.erb @@ -1,8 +1,10 @@ <%= render DS::Dialog.new(frame: "drawer", responsive: true) do |dialog| %> <% dialog.with_header(custom_header: true) do %> -
+
+
+ <%= dialog.close_button %> +
<%= render "trades/header", entry: @entry %> - <%= dialog.close_button %>
<% end %> <% trade = @entry.trade %>