mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 20:14:08 +00:00
Transaction rules engine V1 (#1900)
* Domain model sketch * Scaffold out rules domain * Migrations * Remove existing data enrichment for clean slate * Sketch out business logic and basic tests * Simplify rule scope building and action executions * Get generator working again * Basic implementation + tests * Remove manual merchant management (rules will replace) * Revert "Remove manual merchant management (rules will replace)" This reverts commit 83dcbd9ff0aa7bbee211796b71aa48b71df5e57e. * Family and Provider merchants model * Fix brakeman warnings * Fix notification loader * Update notification position * Add Rule action and condition registries * Rule form with compound conditions and tests * Split out notification types, add CTA type * Rules form builder and Stimulus controller * Clean up rule registry domain * Clean up rules stimulus controller * CTA message for rule when user changes transaction category * Fix tests * Lint updates * Centralize notifications in Notifiable concern * Implement category rule prompts with auto backoff and option to disable * Fix layout bug caused by merge conflict * Initialize rule with correct action for category CTA * Add rule deletions, get rules working * Complete dynamic rule form, split Stimulus controllers by resource * Fix failing tests * Change test password to avoid chromium conflicts * Update integration tests * Centralize all test password references * Add re-apply rule action * Rule confirm modal * Run migrations * Trigger rule notification after inline category updates * Clean up rule styles * Basic attribute locking for rules * Apply attribute locks on user edits * Log data enrichments, only apply rules to unlocked attributes * Fix merge errors * Additional merge conflict fixes * Form UI improvements, ignore attribute locks on manual rule application * Batch AI auto-categorization of transactions * Auto merchant detection, ai enrichment in batches * Fix Plaid merchant assignments * Plaid category matching * Cleanup 1 * Test cleanup * Remove stale route * Fix desktop chat UI issues * Fix mobile nav styling issues
This commit is contained in:
@@ -9,6 +9,8 @@ module Accountable
|
||||
end
|
||||
|
||||
included do
|
||||
include Enrichable
|
||||
|
||||
has_one :account, as: :accountable, touch: true
|
||||
end
|
||||
|
||||
|
||||
63
app/models/concerns/enrichable.rb
Normal file
63
app/models/concerns/enrichable.rb
Normal file
@@ -0,0 +1,63 @@
|
||||
# Enrichable models can have 1+ of their fields enriched by various
|
||||
# external sources (i.e. Plaid) or internal sources (i.e. Rules)
|
||||
#
|
||||
# This module defines how models should, lock, unlock, and edit attributes
|
||||
# based on the source of the edit. User edits always take highest precedence.
|
||||
#
|
||||
# For example:
|
||||
#
|
||||
# If a Rule tells us to set the category to "Groceries", but the user later overrides
|
||||
# a transaction with a category of "Food", we should not override the category again.
|
||||
#
|
||||
module Enrichable
|
||||
extend ActiveSupport::Concern
|
||||
|
||||
InvalidAttributeError = Class.new(StandardError)
|
||||
|
||||
included do
|
||||
scope :enrichable, ->(attrs) {
|
||||
attrs = Array(attrs).map(&:to_s)
|
||||
json_condition = attrs.each_with_object({}) { |attr, hash| hash[attr] = true }
|
||||
where.not(Arel.sql("#{table_name}.locked_attributes ?| array[:keys]"), keys: attrs)
|
||||
}
|
||||
end
|
||||
|
||||
def log_enrichment!(attribute_name:, attribute_value:, source:, metadata: {})
|
||||
de = DataEnrichment.find_or_create_by!(
|
||||
enrichable: self,
|
||||
attribute_name: attribute_name,
|
||||
source: source,
|
||||
)
|
||||
|
||||
de.value = attribute_value
|
||||
de.metadata = metadata
|
||||
de.save!
|
||||
end
|
||||
|
||||
def locked?(attr)
|
||||
locked_attributes[attr.to_s].present?
|
||||
end
|
||||
|
||||
def enrichable?(attr)
|
||||
!locked?(attr)
|
||||
end
|
||||
|
||||
def lock!(attr)
|
||||
update!(locked_attributes: locked_attributes.merge(attr.to_s => Time.current))
|
||||
end
|
||||
|
||||
def unlock!(attr)
|
||||
update!(locked_attributes: locked_attributes.except(attr.to_s))
|
||||
end
|
||||
|
||||
def lock_saved_attributes!
|
||||
saved_changes.keys.reject { |attr| ignored_enrichable_attributes.include?(attr) }.each do |attr|
|
||||
lock!(attr)
|
||||
end
|
||||
end
|
||||
|
||||
private
|
||||
def ignored_enrichable_attributes
|
||||
%w[id updated_at created_at]
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user