Transaction rules engine V1 (#1900)

* Domain model sketch

* Scaffold out rules domain

* Migrations

* Remove existing data enrichment for clean slate

* Sketch out business logic and basic tests

* Simplify rule scope building and action executions

* Get generator working again

* Basic implementation + tests

* Remove manual merchant management (rules will replace)

* Revert "Remove manual merchant management (rules will replace)"

This reverts commit 83dcbd9ff0aa7bbee211796b71aa48b71df5e57e.

* Family and Provider merchants model

* Fix brakeman warnings

* Fix notification loader

* Update notification position

* Add Rule action and condition registries

* Rule form with compound conditions and tests

* Split out notification types, add CTA type

* Rules form builder and Stimulus controller

* Clean up rule registry domain

* Clean up rules stimulus controller

* CTA message for rule when user changes transaction category

* Fix tests

* Lint updates

* Centralize notifications in Notifiable concern

* Implement category rule prompts with auto backoff and option to disable

* Fix layout bug caused by merge conflict

* Initialize rule with correct action for category CTA

* Add rule deletions, get rules working

* Complete dynamic rule form, split Stimulus controllers by resource

* Fix failing tests

* Change test password to avoid chromium conflicts

* Update integration tests

* Centralize all test password references

* Add re-apply rule action

* Rule confirm modal

* Run migrations

* Trigger rule notification after inline category updates

* Clean up rule styles

* Basic attribute locking for rules

* Apply attribute locks on user edits

* Log data enrichments, only apply rules to unlocked attributes

* Fix merge errors

* Additional merge conflict fixes

* Form UI improvements, ignore attribute locks on manual rule application

* Batch AI auto-categorization of transactions

* Auto merchant detection, ai enrichment in batches

* Fix Plaid merchant assignments

* Plaid category matching

* Cleanup 1

* Test cleanup

* Remove stale route

* Fix desktop chat UI issues

* Fix mobile nav styling issues

test/models/rule/action_test.rb

@@ -0,0 +1,61 @@
+require "test_helper"
+
+class Rule::ActionTest < ActiveSupport::TestCase
+  include EntriesTestHelper
+
+  setup do
+    @family = families(:dylan_family)
+    @transaction_rule = rules(:one)
+    @account = @family.accounts.create!(name: "Rule test", balance: 1000, currency: "USD", accountable: Depository.new)
+
+    @grocery_category = @family.categories.create!(name: "Grocery")
+    @whole_foods_merchant = @family.merchants.create!(name: "Whole Foods", type: "FamilyMerchant")
+
+    # Some sample transactions to work with
+    @txn1 = create_transaction(date: Date.current, account: @account, amount: 100, name: "Rule test transaction1", merchant: @whole_foods_merchant).transaction
+    @txn2 = create_transaction(date: Date.current, account: @account, amount: -200, name: "Rule test transaction2").transaction
+    @txn3 = create_transaction(date: 1.day.ago.to_date, account: @account, amount: 50, name: "Rule test transaction3").transaction
+
+    @rule_scope = @account.transactions
+  end
+
+  test "set_transaction_category" do
+    # Does not modify transactions that are locked (user edited them)
+    @txn1.lock!(:category_id)
+
+    action = Rule::Action.new(
+      rule: @transaction_rule,
+      action_type: "set_transaction_category",
+      value: @grocery_category.id
+    )
+
+    action.apply(@rule_scope)
+
+    assert_nil @txn1.reload.category
+
+    [ @txn2, @txn3 ].each do |transaction|
+      assert_equal @grocery_category.id, transaction.reload.category_id
+    end
+  end
+
+  test "set_transaction_tags" do
+    tag = @family.tags.create!(name: "Rule test tag")
+
+    # Does not modify transactions that are locked (user edited them)
+    @txn1.lock!(:tag_ids)
+
+    action = Rule::Action.new(
+      rule: @transaction_rule,
+      action_type: "set_transaction_tags",
+      value: tag.id
+    )
+
+    action.apply(@rule_scope)
+
+    assert_equal [], @txn1.reload.tags
+
+    [ @txn2, @txn3 ].each do |transaction|
+      assert_equal [ tag ], transaction.reload.tags
+    end
+  end
+end

test/models/rule/condition_test.rb

@@ -0,0 +1,128 @@
+require "test_helper"
+
+class Rule::ConditionTest < ActiveSupport::TestCase
+  include EntriesTestHelper
+
+  setup do
+    @family = families(:empty)
+    @transaction_rule = rules(:one)
+    @account = @family.accounts.create!(name: "Rule test", balance: 1000, currency: "USD", accountable: Depository.new)
+
+    @grocery_category = @family.categories.create!(name: "Grocery")
+    @whole_foods_merchant = @family.merchants.create!(name: "Whole Foods", type: "FamilyMerchant")
+
+    # Some sample transactions to work with
+    create_transaction(date: Date.current, account: @account, amount: 100, name: "Rule test transaction1", merchant: @whole_foods_merchant)
+    create_transaction(date: Date.current, account: @account, amount: -200, name: "Rule test transaction2")
+    create_transaction(date: 1.day.ago.to_date, account: @account, amount: 50, name: "Rule test transaction3")
+    create_transaction(date: 1.year.ago.to_date, account: @account, amount: 10, name: "Rule test transaction4", merchant: @whole_foods_merchant)
+    create_transaction(date: 1.year.ago.to_date, account: @account, amount: 1000, name: "Rule test transaction5")
+
+    @rule_scope = @account.transactions
+  end
+
+  test "applies transaction_name condition" do
+    scope = @rule_scope
+
+    condition = Rule::Condition.new(
+      rule: @transaction_rule,
+      condition_type: "transaction_name",
+      operator: "=",
+      value: "Rule test transaction1"
+    )
+
+    scope = condition.prepare(scope)
+
+    assert_equal 5, scope.count
+
+    filtered = condition.apply(scope)
+
+    assert_equal 1, filtered.count
+  end
+
+  test "applies transaction_amount condition using absolute values" do
+    scope = @rule_scope
+
+    condition = Rule::Condition.new(
+      rule: @transaction_rule,
+      condition_type: "transaction_amount",
+      operator: ">",
+      value: "50"
+    )
+
+    scope = condition.prepare(scope)
+
+    filtered = condition.apply(scope)
+    assert_equal 3, filtered.count
+  end
+
+  test "applies transaction_merchant condition" do
+    scope = @rule_scope
+
+    condition = Rule::Condition.new(
+      rule: @transaction_rule,
+      condition_type: "transaction_merchant",
+      operator: "=",
+      value: @whole_foods_merchant.id
+    )
+
+    scope = condition.prepare(scope)
+
+    filtered = condition.apply(scope)
+    assert_equal 2, filtered.count
+  end
+
+  test "applies compound and condition" do
+    scope = @rule_scope
+
+    parent_condition = Rule::Condition.new(
+      rule: @transaction_rule,
+      condition_type: "compound",
+      operator: "and",
+      sub_conditions: [
+        Rule::Condition.new(
+          condition_type: "transaction_merchant",
+          operator: "=",
+          value: @whole_foods_merchant.id
+        ),
+        Rule::Condition.new(
+          condition_type: "transaction_amount",
+          operator: "<",
+          value: "50"
+        )
+      ]
+    )
+
+    scope = parent_condition.prepare(scope)
+
+    filtered = parent_condition.apply(scope)
+    assert_equal 1, filtered.count
+  end
+
+  test "applies compound or condition" do
+    scope = @rule_scope
+
+    parent_condition = Rule::Condition.new(
+      rule: @transaction_rule,
+      condition_type: "compound",
+      operator: "or",
+      sub_conditions: [
+        Rule::Condition.new(
+          condition_type: "transaction_merchant",
+          operator: "=",
+          value: @whole_foods_merchant.id
+        ),
+        Rule::Condition.new(
+          condition_type: "transaction_amount",
+          operator: "<",
+          value: "50"
+        )
+      ]
+    )
+
+    scope = parent_condition.prepare(scope)
+
+    filtered = parent_condition.apply(scope)
+    assert_equal 2, filtered.count
+  end
+end