Fix event handler removal on disconnect (#540)

* Fix event handler removal on disconnect

* Fix tab controller
This commit is contained in:
Jakub Kottnauer
2024-03-11 22:42:18 +01:00
committed by GitHub
parent c60ddaec1d
commit 2c3752668a
5 changed files with 19 additions and 25 deletions

View File

@@ -15,16 +15,14 @@ export default class extends Controller {
}
connect() {
this.inputElements.forEach(el => el.addEventListener('change', this.handler.bind(this)));
this.selectElements.forEach(el => el.addEventListener('change', this.handler.bind(this)));
[...this.inputElements, ...this.selectElements].forEach(el => el.addEventListener('change', this.handler));
}
disconnect() {
this.inputElements.forEach(el => el.removeEventListener('change', this.handler.bind(this)));
this.selectElements.forEach(el => el.removeEventListener('change', this.handler.bind(this)));
[...this.inputElements, ...this.selectElements].forEach(el => el.removeEventListener('change', this.handler));
}
handler(e) {
handler = (e) => {
console.log(e);
this.element.requestSubmit();
}