QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-07 22:34:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix event handler removal on disconnect (#540)

Browse Source 
* Fix event handler removal on disconnect

* Fix tab controller
This commit is contained in:
Jakub Kottnauer
2024-03-11 22:42:18 +01:00
committed by GitHub
parent c60ddaec1d
commit 2c3752668a
5 changed files with 19 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/javascript/controllers/tabs_controller.js
View File

@@ -8,24 +8,22 @@ export default class extends Controller {
connect() {
this.updateClasses(this.defaultTabValue);
document.addEventListener(
"turbo:load",
this.updateClasses.bind(this, this.defaultTabValue)
);
document.addEventListener("turbo:load", this.onTurboLoad);
}
disconnect() {
document.removeEventListener(
"turbo:load",
this.updateClasses.bind(this, this.defaultTabValue)
);
document.removeEventListener("turbo:load", this.onTurboLoad);
}
select(event) {
this.updateClasses(event.target.dataset.id);
}
updateClasses(selectedId) {
onTurboLoad = () => {
this.updateClasses(this.defaultTabValue);
}
updateClasses = (selectedId) => {
this.btnTargets.forEach((btn) => btn.classList.remove(this.activeClass));
this.tabTargets.forEach((tab) => tab.classList.add("hidden"));