Improve dashboard/account charts and tooltips (#2157)

* Improve net worth hover

* Improve graph tooltip

* Use locales files for some text on net worth and account charts

* Consolidate and simplify trend change between net worth and account charts

* Fix test and self-review stuff

* Clean up some stuff on the holding sidebar

config/locales/views/accounts/en.yml

@@ -4,7 +4,7 @@ en:
     account:
       troubleshoot: Troubleshoot
     chart:
-      no_change: no change
+      data_not_available: Data not available for the selected period
     create:
       success: "%{type} account created"
     destroy:

config/locales/views/holdings/en.yml

@@ -9,13 +9,13 @@ en:
       per_share: per share
       shares: "%{qty} shares"
     index:
-      cost: cost
+      average_cost: Average cost
       holdings: Holdings
-      name: name
+      name: Name
       new_holding: New transaction
       no_holdings: No holdings to show.
-      return: total return
-      weight: weight
+      return: Total return
+      weight: Weight
     missing_price_tooltip:
       description: This investment has missing values and we could not calculate
         its returns or value.
@@ -33,5 +33,5 @@ en:
       settings: Settings
       ticker_label: Ticker
       trade_history_entry: "%{qty} shares of %{security} at %{price}"
-      trend_label: Trend
+      total_return_label: Total Return
       unknown: Unknown

config/locales/views/pages/en.yml

@@ -4,6 +4,9 @@ en:
     changelog:
       title: What's new
     dashboard:
+      net_worth_chart:
+        data_not_available: Data not available for the selected period
+        title: Net Worth
       no_account_empty_state:
         new_account: New account
         no_account_subtitle: Since no accounts have been added, there's no data to

config/locales/views/shared/en.yml

@@ -10,3 +10,5 @@ en:
       label: Amount
     syncing_notice:
       syncing: Syncing accounts data...
+    trend_change:
+      no_change: "no change"