QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-07-12 21:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(import): scope leak assertions to account select (#2194 CodeRabbit)

Browse Source 
CodeRabbit nitpick: assert_match on response.body could pass/fail on
text outside the account dropdown (sidebar, breadcrumb, error message,
etc.) and gave false confidence in the refute_match exclusions. Switch
to assert_select 'select[name="import[account_id]"] option', text: …
so the assertions only see the option nodes the leak test actually
cares about.
This commit is contained in:
dripsmvcp
2026-06-05 19:11:37 +09:00
parent e4e64ec82f
commit 35b23da442
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/controllers/import/uploads_controller_test.rb
View File

@@ -41,14 +41,10 @@ class Import::UploadsControllerTest < ActionDispatch::IntegrationTest
get import_upload_url(@import)
assert_response :success
assert_match "Checking Account", response.body,
"Expected the shared account to appear in the account select"
refute_match "Collectable Account", response.body,
"Account select must not leak unshared assets to a non-owner family member"
refute_match "IOU (personal debt to friend)", response.body,
"Account select must not leak unshared liabilities to a non-owner family member"
refute_match "Plaid Depository Account", response.body,
"Account select must not leak unshared connected accounts to a non-owner family member"
assert_select 'select[name="import[account_id]"] option', text: "Checking Account"
assert_select 'select[name="import[account_id]"] option', text: "Collectable Account", count: 0
assert_select 'select[name="import[account_id]"] option', text: "IOU (personal debt to friend)", count: 0
assert_select 'select[name="import[account_id]"] option', text: "Plaid Depository Account", count: 0
end
test "invalid csv cannot be uploaded" do