QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-09-07 07:34:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add configurable OpenAI request timeout (#3304)

Browse Source 
* Add configurable OpenAI request timeout

* Address AI timeout review feedback

---------

Co-authored-by: Jonathan Kaiser <jaysbeekay@users.noreply.github.com>
This commit is contained in:
jaysbeekay
2026-09-02 03:16:53 +02:00
committed by GitHub
co-authored by Jonathan Kaiser
parent 9714612bb1
commit 3a928a0faf
11 changed files with 107 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/controllers/settings/hostings_controller_test.rb
+35 -3
View File
@@ -27,7 +27,7 @@ class Settings::HostingsControllerTest < ActionDispatch::IntegrationTest
teardown do
# These tests persist global Setting.* values; reset them so state can't
# leak into later (order-dependent) tests.
%i[anthropic_access_token anthropic_base_url anthropic_model llm_provider twelve_data_api_key openai_access_token external_assistant_token rentcast_api_key realie_api_key].each do |key|
%i[anthropic_access_token anthropic_base_url anthropic_model llm_provider twelve_data_api_key openai_access_token openai_request_timeout ai_response_timeout external_assistant_token rentcast_api_key realie_api_key].each do |key|
Setting.public_send("#{key}=", nil)
end
end
@@ -550,28 +550,38 @@ class Settings::HostingsControllerTest < ActionDispatch::IntegrationTest
patch settings_hosting_url, params: { setting: {
llm_context_window: "4096",
llm_max_response_tokens: "1024",
llm_max_items_per_call: "40"
llm_max_items_per_call: "40",
openai_request_timeout: "180",
ai_response_timeout: "240"
} }
assert_redirected_to settings_hosting_url
assert_equal 4096, Setting.llm_context_window
assert_equal 1024, Setting.llm_max_response_tokens
assert_equal 40, Setting.llm_max_items_per_call
assert_equal 180, Setting.openai_request_timeout
assert_equal 240, Setting.ai_response_timeout
patch settings_hosting_url, params: { setting: {
llm_context_window: "",
llm_max_response_tokens: "",
llm_max_items_per_call: ""
llm_max_items_per_call: "",
openai_request_timeout: "",
ai_response_timeout: ""
} }
assert_nil Setting.llm_context_window
assert_nil Setting.llm_max_response_tokens
assert_nil Setting.llm_max_items_per_call
assert_nil Setting.openai_request_timeout
assert_nil Setting.ai_response_timeout
end
ensure
Setting.llm_context_window = nil
Setting.llm_max_response_tokens = nil
Setting.llm_max_items_per_call = nil
Setting.openai_request_timeout = nil
Setting.ai_response_timeout = nil
end
test "rejects llm budget below field minimum" do
@@ -593,11 +603,33 @@ class Settings::HostingsControllerTest < ActionDispatch::IntegrationTest
assert_response :unprocessable_entity
assert_match(/must be a whole number/, flash[:alert])
assert_nil Setting.llm_max_items_per_call
patch settings_hosting_url, params: { setting: { openai_request_timeout: "0" } }
assert_response :unprocessable_entity
assert_match(/must be a whole number/, flash[:alert])
assert_nil Setting.openai_request_timeout
end
ensure
Setting.llm_context_window = nil
Setting.llm_max_response_tokens = nil
Setting.llm_max_items_per_call = nil
Setting.openai_request_timeout = nil
end
test "shows environment backed OpenAI request timeout when field is disabled" do
with_self_hosting do
Setting.openai_request_timeout = 180
with_env_overrides("OPENAI_REQUEST_TIMEOUT" => "300") do
get settings_hosting_url
assert_response :success
assert_select "input[name='setting[openai_request_timeout]'][value='300'][disabled='disabled']"
end
end
ensure
Setting.openai_request_timeout = nil
end
test "can clear data only when admin" do