QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 20:14:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor Investment Contributions category handling to use a centralized constant and streamline related logic.

Browse Source
This commit is contained in:
luckyPipewrench
2026-01-20 17:18:49 -05:00
parent 196d12466f
commit 4727a391a7
9 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/models/transfer/creator_test.rb
View File

@@ -7,16 +7,11 @@ class Transfer::CreatorTest < ActiveSupport::TestCase
@destination_account = accounts(:investment)
@date = Date.current
@amount = 100
# Ensure the Investment Contributions category exists for transfer tests
@investment_category = ensure_investment_contributions_category(@family)
end
test "creates investment contribution when transferring from depository to investment" do
# Ensure the Investment Contributions category exists with all required attributes
investment_category = @family.categories.find_or_create_by!(name: "Investment Contributions") do |c|
c.color = "#0d9488"
c.lucide_icon = "trending-up"
c.classification = "expense"
end
creator = Transfer::Creator.new(
family: @family,
source_account_id: @source_account.id,
@@ -36,7 +31,7 @@ class Transfer::CreatorTest < ActiveSupport::TestCase
assert_equal @amount, outflow.entry.amount
assert_equal @source_account.currency, outflow.entry.currency
assert_equal "Transfer to #{@destination_account.name}", outflow.entry.name
assert_equal investment_category, outflow.category, "Should auto-assign Investment Contributions category"
assert_equal @investment_category, outflow.category, "Should auto-assign Investment Contributions category"
# Verify inflow transaction (always funds_movement)
inflow = transfer.inflow_transaction
@@ -75,13 +70,7 @@ class Transfer::CreatorTest < ActiveSupport::TestCase
end
test "creates investment contribution when transferring from depository to crypto" do
# Use crypto account - transfer from depository should be investment_contribution
crypto_account = accounts(:crypto)
investment_category = @family.categories.find_or_create_by!(name: "Investment Contributions") do |c|
c.color = "#0d9488"
c.lucide_icon = "trending-up"
c.classification = "expense"
end
creator = Transfer::Creator.new(
family: @family,
@@ -99,7 +88,7 @@ class Transfer::CreatorTest < ActiveSupport::TestCase
outflow = transfer.outflow_transaction
assert_equal "investment_contribution", outflow.kind
assert_equal "Transfer to #{crypto_account.name}", outflow.entry.name
assert_equal investment_category, outflow.category
assert_equal @investment_category, outflow.category
# Verify inflow transaction with currency handling
inflow = transfer.inflow_transaction