mirror of
https://github.com/we-promise/sure.git
synced 2026-09-03 22:01:16 +00:00
feat(up): map Up category slugs to Sure categories on import (#2487)
* feat(up): map Up category slugs to Sure categories on import UpEntry::Processor captured Up's category slug into extra but never applied it, so Up transactions imported uncategorised even though the user had already tagged them in the Up app. Add UpAccount::Transactions::CategoryTaxonomy + CategoryMatcher, mirroring PlaidAccount::Transactions::CategoryMatcher: map Up's child category slugs onto the family's existing/default Sure categories by alias, and wire the matcher through UpAccount::Transactions::Processor into UpEntry::Processor. The category is applied via the adapter's enrich_attribute, so a category the user has set or locked is preserved on re-sync. High-confidence mappings only. Up-specific categories with no honest Sure default (Booze, Pets, Apps & Games, Life Admin, Technology, ...) intentionally stay uncategorised for the user's own rules / AI, since a wrong auto-category is worse than none. Adds a matcher unit test and processor wiring tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * refactor(up): match category slugs as strings in CategoryMatcher Up category ids are string slugs; compare them against the taxonomy keys as strings so the lookup does not depend on the keys being symbols. No behaviour change (the "slug": hash syntax already produces symbol keys that matched the symbolized input, covered by the matcher unit test), but it removes a subtle footgun and reads clearer. Flagged by the Codex review on the PR. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * fix(up): make category import non-destructive; word-boundary the alias match Per review feedback: do not bootstrap Sure's default categories during a sync. family_categories now returns the family's existing categories without creating defaults, so a family that has none (deliberately cleared, or pre-onboarding) gets uncategorised transactions rather than having the full default set silently created. Matching resumes once the user sets up categories through the normal UI flow. Also word-boundary the "and" stripping in the matcher normalization so it strips only the standalone conjunction, not "and" inside a word (e.g. errand). Adds a processor test for the non-destructive guarantee. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Gavin Matthews <matthews.gav@gmail.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
Gavin Matthews
parent
4d1d33f91d
commit
4e010493c7
@@ -151,4 +151,50 @@ class UpEntry::ProcessorTest < ActiveSupport::TestCase
|
||||
assert_equal "standard", entry.entryable.kind
|
||||
assert_nil entry.entryable.extra.dig("up", "transfer_account_id")
|
||||
end
|
||||
|
||||
test "applies the matched Sure category when a category_matcher is provided" do
|
||||
@family.categories.bootstrap!
|
||||
matcher = UpAccount::Transactions::CategoryMatcher.new(@family.categories.to_a)
|
||||
|
||||
entry = UpEntry::Processor.new(
|
||||
{
|
||||
id: "tx_cat_1",
|
||||
account_id: "acc_123",
|
||||
status: "SETTLED",
|
||||
description: "Woolworths",
|
||||
amount: { currencyCode: "AUD", value: "-40.00", valueInBaseUnits: -4000 },
|
||||
settledAt: "2026-01-15T00:00:00+11:00",
|
||||
createdAt: "2026-01-15T00:00:00+11:00",
|
||||
category_id: "groceries"
|
||||
},
|
||||
up_account: @up_account,
|
||||
category_matcher: matcher
|
||||
).process
|
||||
|
||||
assert_equal "Groceries", entry.transaction.category&.name
|
||||
# The raw Up slug is still preserved in extra for reference.
|
||||
assert_equal "groceries", entry.transaction.extra.dig("up", "category_id")
|
||||
end
|
||||
|
||||
test "leaves the transaction uncategorised when the Up category has no confident match" do
|
||||
@family.categories.bootstrap!
|
||||
matcher = UpAccount::Transactions::CategoryMatcher.new(@family.categories.to_a)
|
||||
|
||||
entry = UpEntry::Processor.new(
|
||||
{
|
||||
id: "tx_cat_2",
|
||||
account_id: "acc_123",
|
||||
status: "SETTLED",
|
||||
description: "BWS",
|
||||
amount: { currencyCode: "AUD", value: "-25.00", valueInBaseUnits: -2500 },
|
||||
settledAt: "2026-01-15T00:00:00+11:00",
|
||||
createdAt: "2026-01-15T00:00:00+11:00",
|
||||
category_id: "booze"
|
||||
},
|
||||
up_account: @up_account,
|
||||
category_matcher: matcher
|
||||
).process
|
||||
|
||||
assert_nil entry.transaction.category_id
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user