Providers factory (#250)

* Implement providers factory

* Multiple providers sync support

- Proper Multi-Provider Syncing: When you click sync on an account with multiple providers (e.g., both Plaid and SimpleFin), all provider items are synced
- Better API: The existing account.providers method already returns all providers, and account.provider returns the first one for backward compatibility
- Correct Holdings Deletion Logic: Holdings can only be deleted if ALL providers allow it, preventing accidental deletions that would be recreated on next sync
TODO: validate this is the way we want to go? We would need to check holdings belong to which account, and then check provider allows deletion. More complex
- Database Constraints: The existing validations ensure an account can have at most one provider of each type (one PlaidAccount, one SimplefinAccount, etc.)

* Add generic provider_import_adapter

* Finish unified import strategy

* Update app/models/plaid_account.rb

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: soky srm <sokysrm@gmail.com>

* Update app/models/provider/factory.rb

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: soky srm <sokysrm@gmail.com>

* Fix account linked by plaid_id instead of external_id

* Parse numerics to BigDecimal

Parse numerics to BigDecimal before computing amount; guard nils.

Avoid String * String and float drift; also normalize date.

* Fix incorrect usage of assert_raises.

* Fix linter

* Fix processor test.

* Update current_balance_manager.rb

* Test fixes

* Fix plaid linked account test

* Add support for holding per account_provider

* Fix proper account access

Also fix account deletion for simpefin too

* FIX match tests for consistency

* Some more factory updates

* Fix account schema for multipe providers

  Can do:
  - Account #1 → PlaidAccount + SimplefinAccount (multiple different providers)
  - Account #2 → PlaidAccount only
  - Account #3 → SimplefinAccount only

  Cannot do:
  - Account #1 → PlaidAccount + PlaidAccount (duplicate provider type)
  - PlaidAccount #123 → Account #1 + Account #2 (provider linked to multiple accounts)

* Fix account setup

- An account CAN have multiple providers (the schema shows account_providers with unique index on [account_id, provider_type])
  - Each provider should maintain its own separate entries
  - We should NOT update one provider's entry when another provider syncs

* Fix linter and guard migration

* FIX linter issues.

* Fixes

- Remove duplicated index
- Pass account_provider_id
- Guard holdings call to avoid NoMethodError

* Update schema and provider import fix

* Plaid doesn't allow holdings deletion

* Use ClimateControl for proper env setup

* No need for this in .git

---------

Signed-off-by: soky srm <sokysrm@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>

test/models/plaid_account/processor_test.rb

@@ -29,31 +29,36 @@ class PlaidAccount::ProcessorTest < ActiveSupport::TestCase
 
     account = Account.order(created_at: :desc).first
     assert_equal "Test Plaid Account", account.name
-    assert_equal @plaid_account.id, account.plaid_account_id
     assert_equal "checking", account.subtype
     assert_equal 1000, account.balance
     assert_equal 1000, account.cash_balance
     assert_equal "USD", account.currency
     assert_equal "Depository", account.accountable_type
     assert_equal "checking", account.subtype
+
+    # Verify AccountProvider was created
+    assert account.linked?
+    assert_equal 1, account.account_providers.count
+    assert_equal @plaid_account.id, account.account_providers.first.provider_id
+    assert_equal "PlaidAccount", account.account_providers.first.provider_type
   end
 
   test "processing is idempotent with updates and enrichments" do
     expect_default_subprocessor_calls
 
-    assert_equal "Plaid Depository Account", @plaid_account.account.name
-    assert_equal "checking", @plaid_account.account.subtype
+    assert_equal "Plaid Depository Account", @plaid_account.current_account.name
+    assert_equal "checking", @plaid_account.current_account.subtype
 
-    @plaid_account.account.update!(
+    @plaid_account.current_account.update!(
       name: "User updated name",
       balance: 2000 # User cannot override balance.  This will be overridden by the processor on next processing
     )
 
-    @plaid_account.account.accountable.update!(subtype: "savings")
+    @plaid_account.current_account.accountable.update!(subtype: "savings")
 
-    @plaid_account.account.lock_attr!(:name)
-    @plaid_account.account.accountable.lock_attr!(:subtype)
-    @plaid_account.account.lock_attr!(:balance) # Even if balance somehow becomes locked, Plaid ignores it and overrides it
+    @plaid_account.current_account.lock_attr!(:name)
+    @plaid_account.current_account.accountable.lock_attr!(:subtype)
+    @plaid_account.current_account.lock_attr!(:balance) # Even if balance somehow becomes locked, Plaid ignores it and overrides it
 
     assert_no_difference "Account.count" do
       PlaidAccount::Processor.new(@plaid_account).process
@@ -61,9 +66,9 @@ class PlaidAccount::ProcessorTest < ActiveSupport::TestCase
 
     @plaid_account.reload
 
-    assert_equal "User updated name", @plaid_account.account.name
-    assert_equal "savings", @plaid_account.account.subtype
-    assert_equal @plaid_account.current_balance, @plaid_account.account.balance # Overriden by processor
+    assert_equal "User updated name", @plaid_account.current_account.name
+    assert_equal "savings", @plaid_account.current_account.subtype
+    assert_equal @plaid_account.current_balance, @plaid_account.current_account.balance # Overriden by processor
   end
 
   test "account processing failure halts further processing" do
@@ -102,7 +107,7 @@ class PlaidAccount::ProcessorTest < ActiveSupport::TestCase
     PlaidAccount::Processor.new(@plaid_account).process
 
     # Verify that the balance was set correctly
-    account = @plaid_account.account
+    account = @plaid_account.current_account
     assert_equal 1000, account.balance
     assert_equal 1000, account.cash_balance
 
@@ -196,7 +201,7 @@ class PlaidAccount::ProcessorTest < ActiveSupport::TestCase
     expect_default_subprocessor_calls
     PlaidAccount::Processor.new(@plaid_account).process
 
-    account = @plaid_account.account
+    account = @plaid_account.current_account
     original_anchor = account.valuations.current_anchor.first
     assert_not_nil original_anchor
     original_anchor_id = original_anchor.id