mirror of
https://github.com/we-promise/sure.git
synced 2026-05-30 07:49:01 +00:00
fix(goals): reconciler logs to Sentry + rename :extend route to :renew
Two Ruby idiom audit fixes. The Reconciler's outer `rescue StandardError` was logging at error level and moving on. Pipeline-protective (we don't want a Goal reconcile failure to break the Plaid/SimpleFIN/etc importer it's hooked into) but invisible — real bugs hid behind a warn log forever. Add `Sentry.capture_exception(e) if defined?(Sentry)` alongside the log, matching the pattern in `Account::Syncer`, `Sync`, `PlaidItem`, and the chart-series rescues this branch already added. Keep the rescue's protective function. `member do patch :extend end` shadows `Module#extend` — the controller action name competes with Ruby's most-common mixin entry point. `before_action :foo, only: %i[extend destroy]` reads as "extend this controller with :foo, only: …" to a casual reader, and stack traces against `def extend` look misleading. Rename to `:renew` (matches the existing copy: the button says "Extend 7 days," but the API verb is "renew the watching window"): - config/routes.rb: `patch :renew` - GoalPledgesController#extend → #renew - locale `goal_pledges.extend` → `goal_pledges.renew` - banner `extend_goal_pledge_path` → `renew_goal_pledge_path` - test refs updated The user-facing button text is unchanged.
This commit is contained in:
@@ -40,14 +40,14 @@ class GoalPledgesControllerTest < ActionDispatch::IntegrationTest
|
||||
|
||||
test "extend pushes expires_at forward" do
|
||||
before = @pledge.expires_at
|
||||
patch extend_goal_pledge_url(@goal, @pledge)
|
||||
patch renew_goal_pledge_url(@goal, @pledge)
|
||||
assert_redirected_to goal_path(@goal)
|
||||
assert @pledge.reload.expires_at > before
|
||||
end
|
||||
|
||||
test "extend on non-open pledge flashes alert" do
|
||||
pledge = goal_pledges(:matched_transfer)
|
||||
patch extend_goal_pledge_url(@goal, pledge)
|
||||
patch renew_goal_pledge_url(@goal, pledge)
|
||||
assert_redirected_to goal_path(@goal)
|
||||
assert flash[:alert].present?
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user