mirror of
https://github.com/we-promise/sure.git
synced 2026-04-19 03:54:08 +00:00
Family sharing (#1272)
* Initial account sharing changes * Update schema.rb * Update schema.rb * Change sharing UI to modal * UX fixes and sharing controls * Scope include in finances better * Update totals.rb * Update totals.rb * Scope reports to finance account scope * Update impersonation_sessions_controller_test.rb * Review fixes * Update schema.rb * Update show.html.erb * FIX db validation * Refine edit permissions * Review items * Review * Review * Add application level helper * Critical review * Address remaining review items * Fix modals * more scoping * linter * small UI fix * Fix: Sync broadcasts push unscoped balance sheet to all users * Update sync_complete_event.rb The fix removes the sidebar broadcasts (which rendered unscoped account groups using family.balance_sheet without user context) along with the now-unused sidebar_targets, account_group, and family_balance_sheet private methods. The sidebar will still update correctly — when the sync completes, Family::SyncCompleteEvent#broadcast fires family.broadcast_refresh, which triggers a morph-based page refresh for each user with their own authenticated session, rendering properly scoped sidebar content.
This commit is contained in:
@@ -19,7 +19,7 @@ class Import::UploadsController < ApplicationController
|
||||
elsif @import.is_a?(SureImport)
|
||||
update_sure_import_upload
|
||||
elsif csv_valid?(csv_str)
|
||||
@import.account = Current.family.accounts.find_by(id: import_account_id)
|
||||
@import.account = accessible_accounts.find_by(id: import_account_id)
|
||||
@import.assign_attributes(raw_file_str: csv_str, col_sep: upload_params[:col_sep])
|
||||
@import.save!(validate: false)
|
||||
|
||||
@@ -78,7 +78,7 @@ class Import::UploadsController < ApplicationController
|
||||
end
|
||||
|
||||
ActiveRecord::Base.transaction do
|
||||
@import.account = Current.family.accounts.find(import_account_id)
|
||||
@import.account = accessible_accounts.find(import_account_id)
|
||||
@import.raw_file_str = QifParser.normalize_encoding(csv_str)
|
||||
@import.save!(validate: false)
|
||||
@import.generate_rows_from_csv
|
||||
|
||||
Reference in New Issue
Block a user