QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 12:04:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(binance): fix hmac signature by using same parameter order in request and sign (#1425)

Browse Source
This commit is contained in:
Louis
2026-04-10 15:40:13 +02:00
committed by GitHub
parent 814f2df570
commit 6551aaee0f
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/models/provider/binance.rb
View File

@@ -91,11 +91,11 @@ class Provider::Binance
def signed_get(path, extra_params: {}) def signed_get(path, extra_params: {})
params = timestamp_params.merge(extra_params) params = timestamp_params.merge(extra_params)
params["signature"] = sign(params) query_string = URI.encode_www_form(params.sort)
response = self.class.get( response = self.class.get(
path, path,
query: params, query: "#{query_string}&signature=#{sign(query_string)}",
headers: auth_headers headers: auth_headers
) )
@@ -106,9 +106,10 @@ class Provider::Binance
{ "timestamp" => (Time.current.to_f * 1000).to_i.to_s, "recvWindow" => "5000" } { "timestamp" => (Time.current.to_f * 1000).to_i.to_s, "recvWindow" => "5000" }
end end
# HMAC-SHA256 of the query string # HMAC-SHA256 of the query string.
# Accepts either a Hash of params or a pre-built query string.
def sign(params) def sign(params)
query_string = URI.encode_www_form(params.sort) query_string = params.is_a?(Hash) ? URI.encode_www_form(params.sort) : params
OpenSSL::HMAC.hexdigest("sha256", api_secret, query_string) OpenSSL::HMAC.hexdigest("sha256", api_secret, query_string)
end end