QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-19 03:54:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rules: Fix no action conditions (#447)

Browse Source 
* Fix Rules page when no action on rule

* Reject new rules without actions

* Rule with no action translation

* Easy one to keep translations going

* Fix tests

* Learn something new every day

---------

Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
This commit is contained in:
Dylan Corrales
2025-12-12 10:58:57 -05:00
committed by GitHub
parent 3e5dfc0263
commit 70b050e4a4
11 changed files with 40 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
test/models/family/data_exporter_test.rb
View File

@@ -24,20 +24,21 @@ class Family::DataExporterTest < ActiveSupport::TestCase
color: "#00FF00"
)
@rule = @family.rules.create!(
@rule = @family.rules.build(
name: "Test Rule",
resource_type: "transaction",
active: true
)
@rule.conditions.create!(
@rule.conditions.build(
condition_type: "transaction_name",
operator: "like",
value: "test"
)
@rule.actions.create!(
@rule.actions.build(
action_type: "set_transaction_category",
value: @category.id
)
@rule.save!
end
test "generates a zip file with all required files" do
@@ -219,20 +220,21 @@ class Family::DataExporterTest < ActiveSupport::TestCase
test "exports rule actions and maps tag UUIDs to names" do
# Create a rule with a tag action
tag_rule = @family.rules.create!(
tag_rule = @family.rules.build(
name: "Tag Rule",
resource_type: "transaction",
active: true
)
tag_rule.conditions.create!(
tag_rule.conditions.build(
condition_type: "transaction_name",
operator: "like",
value: "test"
)
tag_rule.actions.create!(
tag_rule.actions.build(
action_type: "set_transaction_tags",
value: @tag.id
)
tag_rule.save!
zip_data = @exporter.generate_export
@@ -259,28 +261,29 @@ class Family::DataExporterTest < ActiveSupport::TestCase
test "exports compound conditions with sub-conditions" do
# Create a rule with compound conditions
compound_rule = @family.rules.create!(
compound_rule = @family.rules.build(
name: "Compound Rule",
resource_type: "transaction",
active: true
)
parent_condition = compound_rule.conditions.create!(
parent_condition = compound_rule.conditions.build(
condition_type: "compound",
operator: "or"
)
parent_condition.sub_conditions.create!(
parent_condition.sub_conditions.build(
condition_type: "transaction_name",
operator: "like",
value: "walmart"
)
parent_condition.sub_conditions.create!(
parent_condition.sub_conditions.build(
condition_type: "transaction_name",
operator: "like",
value: "target"
)
compound_rule.actions.create!(
compound_rule.actions.build(
action_type: "auto_categorize"
)
compound_rule.save!
zip_data = @exporter.generate_export
@@ -309,19 +312,20 @@ class Family::DataExporterTest < ActiveSupport::TestCase
test "only exports rules from the specified family" do
# Create a rule for another family that should NOT be exported
other_rule = @other_family.rules.create!(
other_rule = @other_family.rules.build(
name: "Other Family Rule",
resource_type: "transaction",
active: true
)
other_rule.conditions.create!(
other_rule.conditions.build(
condition_type: "transaction_name",
operator: "like",
value: "other"
)
other_rule.actions.create!(
other_rule.actions.build(
action_type: "auto_categorize"
)
other_rule.save!
zip_data = @exporter.generate_export