From 814505c5eae2b06464ae6ec86362aa306cfc627a Mon Sep 17 00:00:00 2001
From: Guillem Arias Fauste <accounts@gariasf.com>
Date: Sat, 23 May 2026 08:45:45 +0200
Subject: [PATCH] fix(settings/debugs): migrate in-cell <details> to
 DS::Disclosure :inline (#1916)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

#1858's :inline variant landed (commit 8de14ed2), unblocking the third
sure-design drift finding on this file (#1895 / #1898).

The :inline variant is the right shape for an in-table-cell metadata
expander — no surface, no padding, no shadow; the summary reads as plain
text-link copy. The bot recommended this exact variant when filing the
issues; previous PR (#1903) covered the two token findings but deferred
the <details> migration until the variant was available.

Closes #1895. Closes #1898.
---
 app/views/settings/debugs/show.html.erb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/app/views/settings/debugs/show.html.erb b/app/views/settings/debugs/show.html.erb
index 7d7d6c8b5..d55c4ce46 100644
--- a/app/views/settings/debugs/show.html.erb
+++ b/app/views/settings/debugs/show.html.erb
@@ -87,10 +87,12 @@
                 </td>
                 <td class="px-4 py-3 text-xs text-secondary align-top">
                   <% if entry.metadata.present? %>
-                    <details>
-                      <summary class="cursor-pointer"><%= t(".table.view_metadata") %></summary>
-                      <pre class="mt-2 whitespace-pre-wrap break-words"><%= JSON.pretty_generate(entry.metadata) %></pre>
-                    </details>
+                    <%= render DS::Disclosure.new(variant: :inline) do |disclosure| %>
+                      <% disclosure.with_summary_content do %>
+                        <span class="text-xs text-secondary"><%= t(".table.view_metadata") %></span>
+                      <% end %>
+                      <pre class="whitespace-pre-wrap break-words"><%= JSON.pretty_generate(entry.metadata) %></pre>
+                    <% end %>
                   <% else %>
                     <%= t(".missing_value") %>
                   <% end %>