mirror of
https://github.com/we-promise/sure.git
synced 2026-08-12 11:10:20 +00:00
feat(bank-sync): Wise integration (#2433)
* feat(wise): add Wise integration with JAR savings account and activity support
- Add WiseItem/WiseAccount models with full sync pipeline (importer, syncer, processor)
- Detect income vs expense using targetAccount == recipientId from borderless accounts API
- Support JAR (SAVINGS) accounts with totalWorth balance and savings subtype
- Fetch JAR activity via profile activities API (INTERBALANCE, BALANCE_CASHBACK, BALANCE_ASSET_FEE)
- Route INTERBALANCE activities to both JAR and STANDARD accounts and link as Transfer records
- Add provider connection status registration, routes, views, and i18n
- Add migration for wise_items and wise_accounts tables
- Add tests for WiseAccount, WiseEntry::Processor, WiseActivity::Processor, WiseItem::Importer, and WiseItem#link_jar_transfers!
* chore(lint): add ignore to security scan (false positive)
* fix(wise): address PR review feedback on activity routing, HTML stripping, rate limiting, and scope extraction
- Replace title string matching in activity_for_account? with resource.id vs balance_id comparison to avoid breakage when users rename JAR accounts on Wise
- Replace gsub(/<[^>]+>/, "") with ActionController::Base.helpers.strip_tags to safely handle user-controlled HTML-like content
- Wrap paginated API calls in with_rate_limit_retry (up to 3 attempts, exponential backoff) to handle 429 responses during fetch_jar_activities and fetch_transfers
- Extract WiseAccount.unlinked scope and remove duplicated left_joins query from controller
* fix(wise): address PR #2433 review feedback
- Wire @wise_items into AccountsController#index so linked accounts appear on /accounts
- Fix find_wise_account_for_linking to preserve .active scope via .merge instead of .then
- Fix cross-currency incoming transfer amount to use targetValue instead of sourceValue
- Add missing select_profiles.session_expired locale key
- Add missing account_name interpolation to link_existing_account success notice
- Use i18n for profile type labels in profile_display_name
- Trigger wise_item.sync_later after account linking in all three linking actions
- Isolate fee transaction failure so it no longer aborts the main transfer import
- Use bare raise in WiseActivity/WiseEntry processors to preserve original backtrace
- Re-raise in WiseItem::Unlinking to prevent silently orphaned Holdings
- Fix avatar badge to use design system tokens (bg-container-inset, text-primary)
* fix(wise): fix INTERBALANCE routing and encrypt pending token in session
* fix(wise): replace hand-rolled buttons/links with DS::Button and DS::Link
Address repeated sure-design DS drift findings: migrate all manual
Tailwind button_to and link_to calls in Wise views to DS::Button
(outline/outline_destructive variants) and DS::Link (secondary variant).
Add missing provider_panel.disconnect locale key for the disconnect button text.
* fix(wise): use render_provider_panel_error in create instead of missing new template
* fix(wise): add missing comma in PROVIDERS array
CI failed with a SyntaxError because the questrade entry wasn't
comma-terminated before the wise entry.
* chore(wise): re-add pipelock:ignore for pending token param
Lost when the token source moved from session to an encrypted params
field in 0b5dc886, causing the CI secret scanner to flag a false positive.
* fix(test): widen random ticker suffix to avoid rare collision flake
hex(2) only yields 65536 possible tickers, so create_trade's 4 calls per
test run had a small but nonzero chance of colliding on the unique
ticker+exchange index. hex(8) makes collisions practically impossible.
This commit is contained in:
Generated
+35
@@ -2176,6 +2176,39 @@ ActiveRecord::Schema[7.2].define(version: 2026_07_13_090000) do
|
||||
t.check_constraint "sign_count >= 0", name: "chk_webauthn_credentials_sign_count_non_negative"
|
||||
end
|
||||
|
||||
create_table "wise_accounts", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
|
||||
t.string "balance_id", null: false
|
||||
t.datetime "created_at", null: false
|
||||
t.string "currency", null: false
|
||||
t.decimal "current_balance", precision: 19, scale: 4
|
||||
t.string "name"
|
||||
t.jsonb "raw_payload"
|
||||
t.jsonb "raw_transactions_payload"
|
||||
t.decimal "reserved_balance", precision: 19, scale: 4
|
||||
t.datetime "updated_at", null: false
|
||||
t.uuid "wise_item_id", null: false
|
||||
t.index ["wise_item_id", "balance_id"], name: "index_wise_accounts_on_wise_item_id_and_balance_id", unique: true
|
||||
t.index ["wise_item_id"], name: "index_wise_accounts_on_wise_item_id"
|
||||
end
|
||||
|
||||
create_table "wise_items", id: :uuid, default: -> { "gen_random_uuid()" }, force: :cascade do |t|
|
||||
t.datetime "created_at", null: false
|
||||
t.uuid "family_id", null: false
|
||||
t.string "name", null: false
|
||||
t.boolean "pending_account_setup", default: false, null: false
|
||||
t.string "profile_id", null: false
|
||||
t.string "profile_type", null: false
|
||||
t.jsonb "raw_payload"
|
||||
t.boolean "scheduled_for_deletion", default: false, null: false
|
||||
t.string "status", default: "good", null: false
|
||||
t.datetime "sync_start_date"
|
||||
t.text "token", null: false
|
||||
t.datetime "updated_at", null: false
|
||||
t.index ["family_id", "profile_id"], name: "index_wise_items_on_family_id_and_profile_id", unique: true
|
||||
t.index ["family_id"], name: "index_wise_items_on_family_id"
|
||||
t.index ["status"], name: "index_wise_items_on_status"
|
||||
end
|
||||
|
||||
add_foreign_key "account_providers", "accounts", on_delete: :cascade
|
||||
add_foreign_key "account_shares", "accounts"
|
||||
add_foreign_key "account_shares", "users"
|
||||
@@ -2305,4 +2338,6 @@ ActiveRecord::Schema[7.2].define(version: 2026_07_13_090000) do
|
||||
add_foreign_key "users", "chats", column: "last_viewed_chat_id"
|
||||
add_foreign_key "users", "families"
|
||||
add_foreign_key "webauthn_credentials", "users"
|
||||
add_foreign_key "wise_accounts", "wise_items", on_delete: :cascade
|
||||
add_foreign_key "wise_items", "families"
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user