QT/sure
1
0
Fork 0
mirror of https://github.com/we-promise/sure.git synced 2026-04-23 22:14:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Include subcategories in transaction search filters (#401)

Browse Source 
* Initial plan

* Fix subcategory filtering in transaction search

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Address code review: scope category lookup to family for security

Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>

* Make sure parent categories are not NULL.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jjmata <187772+jjmata@users.noreply.github.com>
Co-authored-by: Juan José Mata <juanjo.mata@gmail.com>
This commit is contained in:
Copilot
2025-12-01 23:38:48 +01:00
committed by GitHub
parent 54d041c4bb
commit 888fa3684a
3 changed files with 92 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/controllers/reports_controller.rb
View File

@@ -408,9 +408,13 @@ class ReportsController < ApplicationController
end
def apply_transaction_filters(transactions)
# Filter by category
# Filter by category (including subcategories)
if params[:filter_category_id].present?
transactions = transactions.where(category_id: params[:filter_category_id])
category_id = params[:filter_category_id]
# Scope to family's categories to prevent cross-family data access
subcategory_ids = Current.family.categories.where(parent_id: category_id).pluck(:id)
all_category_ids = [ category_id ] + subcategory_ids
transactions = transactions.where(category_id: all_category_ids)
end
# Filter by account