Stop the vault tools promising verification they don't perform

Three findings from the automated review passes, all confirmed against the
code before changing anything.

The download URL was dead on arrival for the caller it was built for. Sure
serves stored files through Active Storage controllers that
config/initializers/active_storage_authorization.rb gates on
`viewable_by?(Current.user)` — a signed-in browser session. An MCP client has
a bearer token and no session, so following the URL would have redirected to
sign-in. Removed it rather than leaving a link that cannot work, and the
description now points at search_family_files or the vault UI.

Coverage called a month `covered` when a document merely existed. An
unreconciled statement is not mismatched, so it took the `covered` branch, and
the payload carried nothing to correct the reading — the same "advertised
verification that never happened" bug fixed last round in
get_account_statement, in a second place. Months now carry their own
reconciliation_status, and the description says covered means presence, not
agreement.

Listing filtered visibility after limiting. Beyond underfilling a page, with
no cursor and a 100-row cap an accessible statement behind enough newer
invisible ones was unreachable. Visibility now lives in the query, mirroring
viewable_by? for a statement manager.

Also: rescue unexpected upload failures into a tool error instead of a raw
exception string, derive the documented size limit from MAX_FILE_SIZE, list
every coverage status in mcp.md, and cover the failed-reconciliation and
base64-normalisation branches.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JFDp9HhXDeswadu4cxFojn
This commit is contained in:
Claude
2026-08-01 20:10:34 +00:00
parent 3d5e9efa01
commit 89a2f53126
9 changed files with 122 additions and 54 deletions

View File

@@ -1,10 +1,6 @@
require "test_helper"
class Assistant::Function::GetAccountStatementTest < ActiveSupport::TestCase
include ActiveSupport::Testing::TimeHelpers
DOWNLOAD_TTL_OVERSHOOT = Assistant::Function::GetAccountStatement::DOWNLOAD_URL_TTL + 1.minute
setup do
@user = users(:family_admin)
@account = accounts(:depository)
@@ -69,24 +65,6 @@ class Assistant::Function::GetAccountStatementTest < ActiveSupport::TestCase
assert_nil result[:statement][:reconciliation_note]
end
test "download url carries an expiring signed id" do
statement = create_statement(account: @account)
Rails.application.config.action_mailer.stubs(:default_url_options).returns({ host: "example.com" })
url = @function.call("statement_id" => statement.id).dig(:statement, :download_url)
assert_not_nil url, "expected a download URL when a host is configured"
signed_id = url[%r{/blobs/redirect/([^/]+)/}, 1]
assert_not_nil signed_id, "expected a signed id in #{url}"
assert_equal statement.original_file.blob,
ActiveStorage::Blob.find_signed(signed_id)
travel DOWNLOAD_TTL_OVERSHOOT do
assert_nil ActiveStorage::Blob.find_signed(signed_id),
"signed id must expire — the tool description promises 15 minutes"
end
end
test "returns not_found for an unknown id" do
result = @function.call("statement_id" => SecureRandom.uuid)