fix(savings): DS conformance pass on stepper, ring, card, status pill

- StatusPill: use functional `text-success` / `text-warning` tokens with
  matching icon colors and `px-2 py-1`, mirroring
  `app/views/budget_categories/_budget_category.html.erb:29-43`.
- ProgressRing: rework center text to match `_budget_donut.html.erb`
  (small "Saved" label, `text-3xl font-medium` headline, "of $X"
  underline). Stroke color now derives from goal.status (yellow when
  behind, blue on track, green reached, gray for no-date).
- GoalCard bar: track height + transition match budget category bar
  (`h-1.5`, `transition-all duration-500`, `inline-size`).
- Index/show layouts: render page header inline (`<h1>` + actions). The
  default application layout doesn't yield `:page_actions`, so the
  CTA + kebab menu wouldn't appear when emitted via `content_for`.
- Stepper review summary: target the actual form inputs by `name`
  rather than relying on the `data-target` Stimulus attribute, since
  `money_field` puts the attribute on the wrapper. Step 1 validation
  scoped to the step 1 panel.
- Demo generator: filter Depository accounts via
  `where(accountable_type: "Depository")` — Rails delegated_type
  generates the `depository?` predicate, not a `.depository` scope.
This commit is contained in:
Guillem Arias
2026-05-11 11:39:13 +02:00
parent 77660d2ee4
commit 8a9f4b1a67
12 changed files with 139 additions and 123 deletions

View File

@@ -20,8 +20,8 @@
transform="rotate(-90 <%= Savings::ProgressRingComponent::SIZE / 2.0 %> <%= Savings::ProgressRingComponent::SIZE / 2.0 %>)" />
</svg>
<div class="absolute inset-0 flex flex-col items-center justify-center text-center">
<span class="text-2xl font-semibold text-primary tabular-nums"><%= percent %>%</span>
<span class="text-xs text-secondary tabular-nums mt-1"><%= current_label %></span>
<span class="text-xs text-secondary tabular-nums">of <%= target_label %></span>
<span class="text-secondary text-sm mb-1"><%= t("savings_goals.show.ring.saved") %></span>
<span class="text-3xl font-medium text-primary tabular-nums privacy-sensitive"><%= current_label %></span>
<span class="text-secondary text-sm mt-1 tabular-nums">of <%= target_label %></span>
</div>
</div>